Re: [RFC] GDB Hurd Fixes

2014-05-05 Thread Thomas Schwinge
Hi! On Mon, 5 May 2014 23:49:33 -0400, Samuel Bronson wrote: > On 1/6/14, Thomas Schwinge wrote: > > Sorry for the delay, and thanks for the patches you posted. Here are > > three patches, based on yours, that I intend to apply if there are no > > further comments. > > What happened to applyin

Re: [RFC] GDB Hurd Fixes

2014-05-05 Thread Samuel Bronson
On 1/6/14, Thomas Schwinge wrote: > Hi! > > Sorry for the delay, and thanks for the patches you posted. Here are > three patches, based on yours, that I intend to apply if there are no > further comments. What happened to applying these? (I'd like to cherrypick them for the Debian package.)

Re: let's make libpager single-threaded

2014-05-05 Thread Richard Braun
On Mon, May 05, 2014 at 06:01:17PM +0200, Samuel Thibault wrote: > ? The patch makes both ext2fs's service_paging_requests and libdiskfs' > service_paging_requests become singlethreaded. That's what I call the paging part. The front side, where client calls are processed, is still multithreaded, w

Re: let's make libpager single-threaded

2014-05-05 Thread Samuel Thibault
Richard Braun, le Mon 05 May 2014 17:56:37 +0200, a écrit : > On Mon, May 05, 2014 at 04:55:19PM +0200, Samuel Thibault wrote: > > It's an interesting alternative indeed. This however means our ext2fs > > is not multithreaded any longer, which is a bit sad considered that > > we'll want to go para

Re: let's make libpager single-threaded

2014-05-05 Thread Richard Braun
On Mon, May 05, 2014 at 04:55:19PM +0200, Samuel Thibault wrote: > It's an interesting alternative indeed. This however means our ext2fs > is not multithreaded any longer, which is a bit sad considered that > we'll want to go parallel in the end. Well, no, only the paging part becomes single thre

Re: let's make libpager single-threaded

2014-05-05 Thread Samuel Thibault
Hello, Justus Winter, le Mon 05 May 2014 17:23:10 +0200, a écrit : > Just to make sure I got my idea across. With my change, a single > thread would service all requests to disk pagers, another one would > manage the requests to file pagers. Sure. > And those requests are mostly > IO-bound, and

Re: [PATCH 2/2] fatfs: use two distinct pager buckets for the disk and file pager

2014-05-05 Thread Samuel Thibault
Justus Winter, le Mon 05 May 2014 17:33:12 +0200, a écrit : > fatfs has two kinds of pagers. One for the files, one for the disk. > Previously, both were in the same port bucket. > > If a request for a file pager arrives, it most likely touches some > metadata (like the superblock). This is in t

Re: [PATCH 1/2] libports: unlock _ports_lock on malloc failure

2014-05-05 Thread Samuel Thibault
Justus Winter, le Mon 05 May 2014 17:33:11 +0200, a écrit : > * libports/bucket-iterate.c (_ports_bucket_class_iterate): Unlock > _ports_lock on malloc failure. Ack. > --- > libports/bucket-iterate.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libports/bucket-it

[PATCH 2/2] fatfs: use two distinct pager buckets for the disk and file pager

2014-05-05 Thread Justus Winter
fatfs has two kinds of pagers. One for the files, one for the disk. Previously, both were in the same port bucket. If a request for a file pager arrives, it most likely touches some metadata (like the superblock). This is in turn backed by the disk pager, so another request is generated for the

[PATCH 1/2] libports: unlock _ports_lock on malloc failure

2014-05-05 Thread Justus Winter
* libports/bucket-iterate.c (_ports_bucket_class_iterate): Unlock _ports_lock on malloc failure. --- libports/bucket-iterate.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libports/bucket-iterate.c b/libports/bucket-iterate.c index 498cf13..babc204 100644 --- a/libports/

Re: let's make libpager single-threaded

2014-05-05 Thread Justus Winter
Quoting Samuel Thibault (2014-05-05 16:55:19) > Richard Braun, le Mon 28 Apr 2014 16:55:17 +0200, a écrit : > > But it's certainly on the right path and shouldn't be far from being > > reliable (or at least, a lot more reliable than the current code). We encountered two problems: 1. netdde kept c

Re: let's make libpager single-threaded

2014-05-05 Thread Samuel Thibault
Richard Braun, le Mon 28 Apr 2014 16:55:17 +0200, a écrit : > But it's certainly on the right path and shouldn't be far from being > reliable (or at least, a lot more reliable than the current code). It's an interesting alternative indeed. This however means our ext2fs is not multithreaded any lo

Re: [PATCH 7/9] ext2fs: use two distinct pager buckets for the disk and file pager

2014-05-05 Thread Samuel Thibault
Justus Winter, le Mon 28 Apr 2014 12:20:02 +0200, a écrit : > ext2fs has two kinds of pagers. One for the files, one for the disk. > Previously, both were in the same port bucket. > > If a request for a file pager arrives, it most likely touches some > metadata (like the superblock). This is in

assertion failure in the glibc

2014-05-05 Thread Justus Winter
/* Hi :) I believe I have found two problems in the glibc. 1. hurd_check_cancel takes 'lock', and then asserts that 'critical_section_lock' is not taken. However, hurd_thread_cancel first takes 'critical_section_lock' and then 'lock'. This program demonstrates this by spinning on both

Re: [PATCH 3/3] i386: use ACPI to power off the machine

2014-05-05 Thread Thomas Schwinge
Hi Justus! On Sat, 3 May 2014 01:33:14 +0200, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > This is a mostly verbatim copy of acpihalt.c from GRUB2 with a little > bit of glue code. Perfect, that seems like a good approach to me (that I've had in the back of my head for some years