Re: [PATCH 2/2] vm: make struct vm_map fit into a cache line

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 21:10:47 +0200, a écrit : > Currently, the size of struct vm_map is 68 bytes. By using a bit > field for the boolean flags, it can be made fit into a cache line. Ack. > * vm/vm_map.h (struct vm_map): Use a bit field for the boolean flags > wait_for_space and wir

Re: [PATCH 1/2] i386: fix MACHINE_SERVER_HEADER

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 21:10:46 +0200, a écrit : > Commit b6dab094 introduced a way to include the MIG-generated server > files for the machine specific interface in ipc_kobject.c. > > This broke out-of-tree builds. Here, 'machine' is a symlink to > '../i386/i386', it points into the s

[PATCH 2/2] vm: make struct vm_map fit into a cache line

2014-04-30 Thread Justus Winter
Currently, the size of struct vm_map is 68 bytes. By using a bit field for the boolean flags, it can be made fit into a cache line. * vm/vm_map.h (struct vm_map): Use a bit field for the boolean flags wait_for_space and wiring_required. --- vm/vm_map.h | 7 +-- 1 file changed, 5 insertions(+

[PATCH 1/2] i386: fix MACHINE_SERVER_HEADER

2014-04-30 Thread Justus Winter
Commit b6dab094 introduced a way to include the MIG-generated server files for the machine specific interface in ipc_kobject.c. This broke out-of-tree builds. Here, 'machine' is a symlink to '../i386/i386', it points into the source tree. The MIG-generated files however are put in the build tree

Re: problem installing SVN

2014-04-30 Thread Riccardo Mottola
Hi all, ùjust for the record. Riccardo Mottola wrote: Hi, I had subversion installed, during an apt-get upgrade it broke, if I try to install it now I get: The following packages have unmet dependencies: subversion : Depends: libsvn1 (= 1.7.9-1+nmu3+b1) but it is not going to be installed

Re: [PATCH 2/2] kern: include the MIG-generated server headers for MACHINE_SERVER

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 14:55:16 +0200, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > ipc_kobject_server function. Ack. > *

Re: [PATCH 1/2] include: do not guard the host_slab_info RPC with MACH_VM_DEBUG

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 14:55:15 +0200, a écrit : > Previously, the definition of the host_slab_info RPC was guarded with > MACH_VM_DEBUG, even though it is not at all concerned with the VM > subsystem. Furthermore, there was no "skip" directive for > host_slab_info. > > The function ho

[PATCH 1/2] include: do not guard the host_slab_info RPC with MACH_VM_DEBUG

2014-04-30 Thread Justus Winter
Previously, the definition of the host_slab_info RPC was guarded with MACH_VM_DEBUG, even though it is not at all concerned with the VM subsystem. Furthermore, there was no "skip" directive for host_slab_info. The function host_slab_info is guarded with MACH_DEBUG. The server for the RPCs in mac

[PATCH 2/2] kern: include the MIG-generated server headers for MACHINE_SERVER

2014-04-30 Thread Justus Winter
GNU MIG recently gained support for emitting x_server_routine declarations in the generated server header file. Using this declaration, the x_server_routine functions can be inlined into the ipc_kobject_server function. * kern/ipc_kobject.c: Include the MIG-generated server headers for the machin

Re: [PATCH 2/2] Install the mach_debug header files

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 13:13:59 +0200, a écrit : > The task_set_name RPC introduced in 877a319c changed > include/mach/gnumach.defs to include mach_debug/mach_debug_types.defs. > Previously though, the debug headers were not installed. Ack. > * Makefrag.am: Install the mach_debug heade

Re: [PATCH 1/2] doc: fix the number of priorities

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 13:13:58 +0200, a écrit : > The number of priorities has been changed from 32 to 50 in > 6a234201081156e6d5742e7eeabb68418b518fad. Ack. > * doc/mach.texi: Update accordingly. > --- > doc/mach.texi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

[PATCH 2/2] Install the mach_debug header files

2014-04-30 Thread Justus Winter
The task_set_name RPC introduced in 877a319c changed include/mach/gnumach.defs to include mach_debug/mach_debug_types.defs. Previously though, the debug headers were not installed. * Makefrag.am: Install the mach_debug header files. --- Makefrag.am | 15 --- 1 file changed, 12 inserti

[PATCH 1/2] doc: fix the number of priorities

2014-04-30 Thread Justus Winter
The number of priorities has been changed from 32 to 50 in 6a234201081156e6d5742e7eeabb68418b518fad. * doc/mach.texi: Update accordingly. --- doc/mach.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/mach.texi b/doc/mach.texi index d089224..49c0d67 100644 --- a/d

Re: [PATCH 4/4] tmpfs: improve diskfs_node_iterate

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 11:06:02 +0200, a écrit : > Currently, diskfs_node_iterate iterates twice over all nodes. The > first time only to determine the number of nodes. Simply count them > instead. Ack. > * tmpfs/node.c (all_nodes_nr_items): New variable. > (diskfs_free_node): Decrem

Re: [PATCH 3/4] fatfs: improve diskfs_node_iterate

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 11:06:01 +0200, a écrit : > Currently, diskfs_node_iterate iterates twice over all nodes in the > cache. The first time only to determine the number of nodes currently > in the cache. Simply count them instead. Ack. > * fatfs/inode.c (nodehash_nr_items): New va

Re: [PATCH 2/4] ext2fs: improve diskfs_node_iterate

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 11:06:00 +0200, a écrit : > Currently, diskfs_node_iterate iterates twice over all nodes in the > cache. The first time only to determine the number of nodes currently > in the cache. Simply count them instead. Ack. > * ext2fs/inode.c (nodehash_nr_items): New v

Re: [PATCH 1/4] fatfs: simplify expression

2014-04-30 Thread Samuel Thibault
Justus Winter, le Wed 30 Apr 2014 11:05:59 +0200, a écrit : > * fatfs/pager.c (add_pager_max_prot): Simplify expression. Ack. > --- > fatfs/pager.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fatfs/pager.c b/fatfs/pager.c > index 8146e64..6180aac 100644 > --- a/fa

[PATCH 4/4] tmpfs: improve diskfs_node_iterate

2014-04-30 Thread Justus Winter
Currently, diskfs_node_iterate iterates twice over all nodes. The first time only to determine the number of nodes. Simply count them instead. * tmpfs/node.c (all_nodes_nr_items): New variable. (diskfs_free_node): Decrement all_nodes_nr_items. (diskfs_node_norefs): Likewise. (diskfs_cached_looku

[PATCH 3/4] fatfs: improve diskfs_node_iterate

2014-04-30 Thread Justus Winter
Currently, diskfs_node_iterate iterates twice over all nodes in the cache. The first time only to determine the number of nodes currently in the cache. Simply count them instead. * fatfs/inode.c (nodehash_nr_items): New variable. (diskfs_cached_lookup): Increment nodehash_nr_items. (diskfs_cache

[PATCH 1/4] fatfs: simplify expression

2014-04-30 Thread Justus Winter
* fatfs/pager.c (add_pager_max_prot): Simplify expression. --- fatfs/pager.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fatfs/pager.c b/fatfs/pager.c index 8146e64..6180aac 100644 --- a/fatfs/pager.c +++ b/fatfs/pager.c @@ -1008,8 +1008,7 @@ diskfs_max_user_pager_prot ()

[PATCH 2/4] ext2fs: improve diskfs_node_iterate

2014-04-30 Thread Justus Winter
Currently, diskfs_node_iterate iterates twice over all nodes in the cache. The first time only to determine the number of nodes currently in the cache. Simply count them instead. * ext2fs/inode.c (nodehash_nr_items): New variable. (diskfs_cached_lookup): Increment nodehash_nr_items. (diskfs_node