Re: [PATCH 4/6] libmachdev: drop unused declarations

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:12 +0200, a écrit : > * libmachdev/net.c (linux_intr_pri): Drop unused declaration. > (port_bucket): Likewise. > (dev_class): Likewise. Ack. > --- > libmachdev/net.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libmachdev/net.c b/libmachdev

Re: [PATCH 6/6] libmachdev: add, fix and use declaration for create_device_port

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:14 +0200, a écrit : > * libmachdev/ds_routines.c (create_device_port): Fix the type of the > size parameter. Make it return error_t. > * libmachdev/ds_routines.h (create_device_port): Add declaration. > * libmachdev/net.c: Include ds_routines.h. > * libmachd

Re: [PATCH 5/6] libmachdev: add missing includes

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:13 +0200, a écrit : > Include the mig-generated X_S.h files so that the X_routine functions > can be inlined into the demuxer functions. Ack. > * libmachdev/ds_routines.c: Add missing include of notify_S.h > * libmachdev/trivfs_server.c: Add missing include

Re: [PATCH 3/6] libmachdev: make the two port buckets clearly distinct

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:11 +0200, a écrit : > libmachdev uses two port buckets previously both named port_bucket. > Rename the one containing device_t ports to device_bucket to clearly > distinguish them. Ack. > * libmachdev/ds_routines.c (port_bucket): Rename to device_bucket. >

Re: [PATCH 1/6] libmachdev: fix device_open

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:09 +0200, a écrit : > device_open used to explicitly call ds_device_open_reply instead of > just letting the mig-generated wrapper around ds_device_open generate > the return message. There is really no need for that. Ack. > * libmachdev/net.c: Do not incl

Re: [PATCH 2/6] libmachdev: remove mach_device_deallocate

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 13:43:10 +0200, a écrit : > mach_device_deallocate just called ports_port_deref. However, the > reference counting is done by the translation functions, explicitly > reducing the reference count is just wrong. Ack. > * libmachdev/ds_routines.c (mach_device_deall

Re: Problem with glibc and libihash

2014-04-13 Thread Samuel Thibault
Manolis Ragkousis, le Sun 13 Apr 2014 21:50:17 +, a écrit : > First of all libihash and any of the hurd libraries cannot be built > without a working glibc. Hurd libs depend heavily on header files > found in glibc like "lowlevellock.h", Mmm, if it's only headers, wouldn't it be possible to in

Problem with glibc and libihash

2014-04-13 Thread Manolis Ragkousis
First of all libihash and any of the hurd libraries cannot be built without a working glibc. Hurd libs depend heavily on header files found in glibc like "lowlevellock.h", so even after making the build system of the hurd repository to accept not to be able to build programs (as Samuel suggested),

[PATCH 5/6] libmachdev: add missing includes

2014-04-13 Thread Justus Winter
Include the mig-generated X_S.h files so that the X_routine functions can be inlined into the demuxer functions. * libmachdev/ds_routines.c: Add missing include of notify_S.h * libmachdev/trivfs_server.c: Add missing include of device_S.h, and notify_S.h. --- libmachdev/ds_routines.c | 1 + lib

[PATCH 4/6] libmachdev: drop unused declarations

2014-04-13 Thread Justus Winter
* libmachdev/net.c (linux_intr_pri): Drop unused declaration. (port_bucket): Likewise. (dev_class): Likewise. --- libmachdev/net.c | 4 1 file changed, 4 deletions(-) diff --git a/libmachdev/net.c b/libmachdev/net.c index 300d946..6037e2f 100644 --- a/libmachdev/net.c +++ b/libmachdev/net.c

[PATCH 6/6] libmachdev: add, fix and use declaration for create_device_port

2014-04-13 Thread Justus Winter
* libmachdev/ds_routines.c (create_device_port): Fix the type of the size parameter. Make it return error_t. * libmachdev/ds_routines.h (create_device_port): Add declaration. * libmachdev/net.c: Include ds_routines.h. * libmachdev/block.c: Include ds_routines.h. --- libmachdev/block.c | 1 +

[PATCH 3/6] libmachdev: make the two port buckets clearly distinct

2014-04-13 Thread Justus Winter
libmachdev uses two port buckets previously both named port_bucket. Rename the one containing device_t ports to device_bucket to clearly distinguish them. * libmachdev/ds_routines.c (port_bucket): Rename to device_bucket. * libmachdev/mig-decls.h: Likewise. --- libmachdev/ds_routines.c | 8 --

[PATCH 2/6] libmachdev: remove mach_device_deallocate

2014-04-13 Thread Justus Winter
mach_device_deallocate just called ports_port_deref. However, the reference counting is done by the translation functions, explicitly reducing the reference count is just wrong. * libmachdev/ds_routines.c (mach_device_deallocate): Remove now unused function. (ds_device_close): Drop spurious call

more dde fixes

2014-04-13 Thread Justus Winter
Some more fixes for the code in the dde branch of the incubator. Justus

[PATCH 1/6] libmachdev: fix device_open

2014-04-13 Thread Justus Winter
device_open used to explicitly call ds_device_open_reply instead of just letting the mig-generated wrapper around ds_device_open generate the return message. There is really no need for that. * libmachdev/net.c: Do not include device_reply_U.h. (device_open): Do not call ds_device_open_reply. Set

Re: [PATCH] kern: set the name of tasks created during the bootstrap

2014-04-13 Thread Samuel Thibault
Justus Winter, le Sun 13 Apr 2014 09:21:05 +0200, a écrit : > * kern/bootstrap.c (boot_script_task_create): Set the name of newly > created tasks. Ack. > --- > kern/bootstrap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kern/bootstrap.c b/kern/bootstrap.c > index 7cfff3a..d919e90

[PATCH] kern: set the name of tasks created during the bootstrap

2014-04-13 Thread Justus Winter
* kern/bootstrap.c (boot_script_task_create): Set the name of newly created tasks. --- kern/bootstrap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kern/bootstrap.c b/kern/bootstrap.c index 7cfff3a..d919e90 100644 --- a/kern/bootstrap.c +++ b/kern/bootstrap.c @@ -800,6 +800,7 @@ boot_scrip