Re: [PATCH] Steal all string functions from the libc

2014-03-28 Thread Samuel Thibault
Justus Winter, le Fri 28 Mar 2014 16:22:14 +0100, a écrit : > Steal all string functions previously implemented in kern/strings.c > from the libc. Those are most likely more optimized than our simple > implementations. Well, we used to do that in the past, actually, and ended up into various kind

Re: [PATCH] Steal all string functions from the libc

2014-03-28 Thread Samuel Thibault
Samuel Thibault, le Fri 28 Mar 2014 16:33:39 +0100, a écrit : > see a disassemble of memcpy, it ends up being a rep movsb > %ds:(%esi),%es:(%edi), which is just exactly what we need to tell the > processor). Oops, sorry, wrong example, that one is coming from libc. Anyway, relying on the host libc

[PATCH] Steal all string functions from the libc

2014-03-28 Thread Justus Winter
Steal all string functions previously implemented in kern/strings.c from the libc. Those are most likely more optimized than our simple implementations. * Makefile.am (clib_routines): Add memset, strcmp, strncmp, strcpy, strncpy, and strlen. * Makefrag.am (libkernel_a_SOURCES): Drop kern/strings.

Re: [PATCH] Steal all string functions from the libc

2014-03-28 Thread Roland McGrath
You need to take care for the cases that might be (now or in the future) using ifunc.