Re: [GSOC] Porting Valgrind to Hurd

Hello, here is my initial coverage of teching valgrind ioctl. Some notes have been left out, will fill it when I get some time - but need to prepare for university exams that are starting tomorrow. On Tue, Mar 25, 2014 at 6:32 AM, Samuel Thibault wrote: > Subhashish Pradhan, le Thu 20 Mar 2014

Re: [PATCH 3/4] mach-defpager: fix local includes

Justus Winter, le Wed 19 Mar 2014 11:31:10 +0100, a écrit : > * mach-defpager/default_pager.c: Fix local includes. > * mach-defpager/main.c: Likewise. > * mach-defpager/setup.c: Likewise. Ack. > --- > mach-defpager/default_pager.c | 8 > mach-defpager/main.c | 2 +- > mach-defp

Re: [PATCH 2/4] mach-defpager: fix receiver lookups

Justus Winter, le Wed 19 Mar 2014 11:31:09 +0100, a écrit : > Previously, the receiver lookup was done manually in all the server > functions. Use mig translator functions instead. Ack. > * mach-defpager/mig-decls.h: New file. > * mach-defpager/mig-mutate.h: Likewise. > * mach-defpager/Makefile

Re: [PATCH 1/4] hurd: fix receiver type, honor DEFAULT_PAGER_IMPORTS

Justus Winter, le Wed 19 Mar 2014 11:31:08 +0100, a écrit : > * hurd/default_pager.defs: Honor DEFAULT_PAGER_IMPORTS. > (default_pager_object_set_size): Fix receiver type. Ack. > --- > hurd/default_pager.defs | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hurd/def

Re: [PATCH] include: make the memory_object_t types translation functions mutable

Justus Winter, le Wed 19 Mar 2014 11:25:44 +0100, a écrit : > Make the intran, outtran and destructor functions mutable using > preprocessor macros. Make it possible to inject imports using the > MEMORY_OBJECT_IMPORTS macro. This way, userspace servers can provide > their own translation function

Re: [PATCH 2/3] isofs: also copy the terminating zero in read_symlink_hook

On 03/20/2014 02:01 PM, Justus Winter wrote: * isofs/inode.c (read_symlink_hook): Use memcpy, also copy terminating zero. --- Are you interested in getting rid of the outdated bcopy() ? I have got a Coccinelle patch ready :) Regards, Cyril.

Re: [PATCH 2/2] libpager: fix potential deadlock

Justus Winter, le Fri 21 Mar 2014 13:57:53 +0100, a écrit : > This patch releases the interlock before doing an rpc call, analogous > to 901c61a1d25e7c8963e51012760a82730eda1910. > > * libpager/pager-attr.c (pager_change_attributes): Release interlock > before calling memory_object_change_attribut

Re: [PATCH 1/2] libpager: fix comment of pager_change_attributes

Justus Winter, le Fri 21 Mar 2014 13:57:52 +0100, a écrit : > * libpager/pager-attr.c: Fix comment. > * libpager/pager.h: Likewise. Ack. > --- > libpager/pager-attr.c | 6 +++--- > libpager/pager.h | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libpager/pag

Re: [PATCH 1/3] ext2fs: remove inappropriate assertion

Justus Winter, le Thu 20 Mar 2014 14:01:18 +0100, a écrit : > find_block may very well return no error but set block to zero. This > indicates that the block in question has not been allocated. Skip > those blocks instead. Mmm, I don't think we want to skip them. AIUI (but don't take my words f

Re: [PATCH 2/3] isofs: also copy the terminating zero in read_symlink_hook

Justus Winter, le Thu 20 Mar 2014 14:01:19 +0100, a écrit : > * isofs/inode.c (read_symlink_hook): Use memcpy, also copy terminating > zero. Ack. > --- > isofs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/isofs/inode.c b/isofs/inode.c > index f9d4c41..f542d18

Re: [PATCH 3/3] libdiskfs: fix string termination

Justus Winter, le Thu 20 Mar 2014 14:01:20 +0100, a écrit : > Found using the Clang Static Analyzer. > > * libdiskfs/fsys-getroot.c (diskfs_S_fsys_getroot): Fix string > termination. Ack. > --- > libdiskfs/fsys-getroot.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff

Re: [GSOC] Porting Valgrind to Hurd

Subhashish Pradhan, le Thu 20 Mar 2014 22:26:15 +0530, a écrit : > I found kern/syscall_sw.c couple of days ago and was wondering about the > difference between the .h and .c variants; but I waited for your feedback. > The implemented traps matter. But are the others a dummy filler to be > implemen