On Wed, Dec 11, 2013 at 09:07:38PM +0100, Marin Ramesa wrote:
> On 11.12.2013 18:02:50, Richard Braun wrote:
> > On Wed, Dec 11, 2013 at 05:30:43PM +0100, Marin Ramesa wrote:
> > > - ipc_mqueue_t mqueue;
> > > + ipc_mqueue_t mqueue = mqueue; /* Quiet GCC warning. */
> >
> > Don't do that. Instead,
> Unless I'm mistaken, their semantics imply executable stacks,
You are mistaken. Only certain kinds of uses require that.
There are no such uses in libc, for example.
> Marin Ramesa writes:
> On 11.12.2013 19:12:33, Ivan Shmakov wrote:
>> Even though I’m unsure how vm_offset_t is defined (is it int? or is
>> it ptrdiff_t? ¹), I’d rather like to see casts to /int/ here, as
>> it’s what %X (usually – no idea about vm/*) implies.
>> ¹ Please note th
On 11.12.2013 19:12:33, Ivan Shmakov wrote:
>
> Even though I’m unsure how vm_offset_t is defined (is it int?
> or is it ptrdiff_t? ¹), I’d rather like to see casts to /int/
> here, as it’s what %X (usually – no idea about vm/*) implies.
>
> ¹ Please note that while int is 32 bits on
On 11.12.2013 18:02:50, Richard Braun wrote:
> On Wed, Dec 11, 2013 at 05:30:43PM +0100, Marin Ramesa wrote:
> > - ipc_mqueue_t mqueue;
> > + ipc_mqueue_t mqueue = mqueue; /* Quiet GCC warning. */
>
> Don't do that. Instead, tweak simple_unlock and similar functions
> this way :
>
> #define
> Marin Ramesa writes:
> Members offset and phys_addr are of vm_offset_t types.
> * vm/vm_resident.c (vm_page_print) (offset, phys_addr): Remove
> unnecessary casts.
[…]
> iprintf("Page 0x%X: object 0x%X,", (vm_offset_t) p, (vm_offset_t)
> p->object);
> - printf(" offset 0x
On Wed, Dec 11, 2013 at 05:30:43PM +0100, Marin Ramesa wrote:
> - ipc_mqueue_t mqueue;
> + ipc_mqueue_t mqueue = mqueue; /* Quiet GCC warning. */
Don't do that. Instead, tweak simple_unlock and similar functions this
way :
#define simple_unlock(l) ((void)(l))
--
Richard Braun
This is again that code where variable is assigned to itself, but
I don't know how to fix this the other way.
* server.c (WriteVarDecls) (msgh_simple): Assign to itself.
---
server.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server.c b/server.c
index 8496da7..793b9f
Members offset and phys_addr are of vm_offset_t types.
* vm/vm_resident.c (vm_page_print) (offset, phys_addr): Remove unnecessary
casts.
---
vm/vm_resident.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vm/vm_resident.c b/vm/vm_resident.c
index f0f31f6..dc99a79 100644
The return value from vm_map_min() is already of vm_offset_t type.
* vm/vm_kern.c (kmem_submap) (addr): Remove unnecessary cast.
---
vm/vm_kern.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vm/vm_kern.c b/vm/vm_kern.c
index 7e377ef..1c843ff 100644
--- a/vm/vm_kern.c
+++ b
* i386/i386/ldt.c (syscall): Remove forward declaration.
Include locore.h.
* i386/i386/locore.h (syscall): Add prototype.
---
i386/i386/ldt.c| 3 +--
i386/i386/locore.h | 2 ++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/i386/i386/ldt.c b/i386/i386/ldt.c
index 43b9efb..f9b6
This is the second way to quiet GCC warnings about set but unused
variables during simple locks. The first one is here:
http://lists.gnu.org/archive/html/bug-hurd/2013-12/msg6.html
Third way would be to declare an set mqueue and obj only if MACH_SLOCKS.
* ipc/ipc_port.c (ipc_port_set_seqno)
* device/ds_routines.c (device_write_trap) (copyin) (data): Cast to (void *).
Argument is an address.
(device_write_trap) (copyin) (io_data): Don't cast. Argument is a pointer.
(device_writev_trap) (copyin) (iovec): Likewise.
(device_writev_trap) (copyin) (stack_iovec): Likewise.
(device_writev_tr
This is mach_clock.c, not clock_prim.c.
* kern/mach_clock.c: Update comment.
---
kern/mach_clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kern/mach_clock.c b/kern/mach_clock.c
index 29a14c9..c0ec471 100644
--- a/kern/mach_clock.c
+++ b/kern/mach_clock.c
@@ -27,7 +27,
I don't know if I done this correctly. I don't know much about
MIG and generated code. Function memory_object_create_proxy()
should really have a pointer to ipc_port_t as a third argument.
In this way, the resulting forward declaration is slightly
incorrect, but the call to function works without
This allows one to rpctrace processes doing select(2).
* utils/rpctrace.c (trace_and_forward): Handle MACH_MSG_TYPE_PORT_SEND
rights.
---
utils/rpctrace.c |4
1 file changed, 4 insertions(+)
diff --git a/utils/rpctrace.c b/utils/rpctrace.c
index 5d3b2ca..b39b2e3 100644
--- a/utils/rpctr
Currently, rpctrace dies if a tracee uses select(2) because it asserts
that reply_type is a MACH_MSG_TYPE_PORT_SEND_ONCE right. Generalize
the code surrounding the failing assertion.
* utils/rpctrace.c (trace_and_forward): Generalize code by switching
over reply_type.
---
utils/rpctrace.c | 40
* utils/rpctrace.c (rewrite_right): Generalize the code so we can use
rewrite_right to rewrite MACH_MSG_TYPE_PORT_SEND rights for non-rpc ports.
---
utils/rpctrace.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/utils/rpctrace.c b/utils/rpctrace.c
index ef7ab53..9433ef3
Justus Winter, le Wed 11 Dec 2013 10:28:52 +0100, a écrit :
> ping ;)
EBUSY :)
ping ;)
Justus
20 matches
Mail list logo
