[PATCH 2/6] mount: implement -O, --test-opts

2013-07-05 Thread Justus Winter
--test-opts in combination with --all mounts only those filesystems with options matching the given set of options. Note that the semantic of the inverting "no" prefix differs from --types: While --types=nonfs,ufs means neither nfs nor ufs, --test-opts=nofoo,bar means not foo, but bar. * utils/ma

[PATCH 6/6] umount: add a umount utility

2013-07-05 Thread Justus Winter
This adds a umount utility that implements most of the functions that the Linux umount utility provides, especially that subset that is used by the Debian package initscripts. * utils/umount.c: New file. --- utils/Makefile | 10 +- utils/umount.c | 319 +

[PATCH 1/6] sutils: fix the semantic of -t, --types in fstab.c

2013-07-05 Thread Justus Winter
The mount utility on both Linux and FreeBSD allows one to either specify a whitelist or a blacklist of filesystem types to consider for --all. Prefixing the list with "no" indicates that the list is a blacklist. Furthermore, Linux' mount utility ignores a "no" prefix on any entry in the given list.

[PATCH 5/6] sutils: allow multiple entries for the device "none"

2013-07-05 Thread Justus Winter
Previously it was not possible to add two mount entries with the same device information to an fstab structure. This is easily fixed by breaking the assumption, that there is only one possible mount entry for the "none" device as used by many purely virtual file systems. * utils/fstab.c (fstab_fin

[PATCH 4/6] mount: handle -t auto

2013-07-05 Thread Justus Winter
Use libblkid to detect the filesystem type if "auto" is given as type. Remove the translator localization from main, this is also done in do_mount and any errors are propagated properly. This way "auto" is handled correctly if given on the command line or used as filesystem type in the fstab. * ut

[PATCH 3/6] mount: ignore mounted filesystems if --all is given

2013-07-05 Thread Justus Winter
Linux' mount utility ignores mounted filesystems if mount --all is invoked. This patch makes our mount do the same. utils/mount.c (main): Ignore mounted filesystems if --all is given. --- utils/mount.c |9 + 1 file changed, 9 insertions(+) diff --git a/utils/mount.c b/utils/mount.c i

Updated patch series for mount, umount

2013-07-05 Thread Justus Winter
This is the same series as send in [0], but the umount patch has been updated. Among minor stylistic changes it makes umount assume that a given argument is the mount point if looking it up as device or mount point in the mtab file fails. This makes the umount utility somewhat useful even on system

Re: [PATCH, gnumach] ddb: fix implicit declarations

2013-07-05 Thread Marin Ramesa
On 05.07.2013 09:45:39, Samuel Thibault wrote: > Err, no, the point of putting it in a .h file is to put it into a > single place, so you're sure everybody agree on the definition since > it's written only once. The .h file where it's supposed to go has to > be related with the function itself, e

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Justus Winter
Quoting Cyril Roelandt (2013-07-05 10:35:18) > On 07/05/2013 09:33 AM, Justus Winter wrote: > > In your patches the variable state is misspelled sate. How did that > > happen? Your script doesn't seem to include the typo. > > Because the variable is actually named "sate" in the code :) Look at >

[PATCH] swapon: add -v, --verbose argument

2013-07-05 Thread Justus Winter
This patch adds a --verbose argument to swapon and swapoff to make it more compatible with the corresponding Linux' utilities. Note that our swapon is verbose by default and has a --quiet argument to make it quiet, so a --verbose argument on it's own does nothing at all. * sutils/swapon.c (main):

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Cyril Roelandt
On 07/05/2013 09:33 AM, Justus Winter wrote: In your patches the variable state is misspelled sate. How did that happen? Your script doesn't seem to include the typo. Because the variable is actually named "sate" in the code :) Look at mboxfs/mboxfs.c, for instance. Cyril Roelandt.

Re: [PATCH, gnumach] ddb: fix implicit declarations

2013-07-05 Thread Samuel Thibault
Marin Ramesa, le Fri 05 Jul 2013 08:23:22 +0200, a écrit : > On 04.07.2013 23:11:19, Samuel Thibault wrote: > > Please rather put it into a .h file. > > * ddb/db_command.h (_setjmp): Add prototype. > * kern/xpr.h (_setjmp): Add prototype. Err, no, the point of putting it in a .h file is to put i

Re: [PATCH] Gracefully handle errors using argp_error().

2013-07-05 Thread Justus Winter
Hi :), Quoting Cyril Roelandt (2013-07-05 01:25:26) > Hello! > > After seeing this patch from Justus Winter: > > http://lists.gnu.org/archive/html/bug-hurd/2013-06/msg00120.html > > I wrote a Coccinelle script that finds similar errors: Coccinelle is quite awesome :) we should try to find port