Re: [PATCH 1/6] procfs: fix the error handling in argp_parser

2013-06-29 Thread Justus Winter
Quoting Samuel Thibault (2013-06-29 22:11:21) > Justus Winter, le Fri 28 Jun 2013 18:37:40 +0200, a écrit : > > Do not exit using error (1, ..) but gracefully handle the error using > > argp_error. Also fix a typo ("the a user") while touching these lines. > > > > * procfs/main.c (argp_parser): Pr

Re: Contributing

2013-06-29 Thread Samuel Thibault
Hello, Cris Mihalache, le Tue 25 Jun 2013 12:12:06 +, a écrit : > Once I finish, I'd like to help out with Hurd/Mach development, but I would > appreciate some pointers on starting :) Any simple things I can tackle to > begin > with? How should I approach it? I guess you have read http://www

[task #7489] Support LBA48

2013-06-29 Thread Samuel Thibault
Follow-up Comment #2, task #7489 (project hurd): Note: the ahci driver has lba48 support. The Mach interface is still limited to 32bit sector count, however. ___ Reply to this item at: _

Re: some work on procfs

2013-06-29 Thread Samuel Thibault
I have also applied patches 2 and 3. 4, 5 and 6, more involved author-right-wise, will have to wait for the FSF papers, but they look OK, I'll upload them in the Debian package. Samuel

Re: [PATCH 1/6] procfs: fix the error handling in argp_parser

2013-06-29 Thread Samuel Thibault
Justus Winter, le Fri 28 Jun 2013 18:37:40 +0200, a écrit : > Do not exit using error (1, ..) but gracefully handle the error using > argp_error. Also fix a typo ("the a user") while touching these lines. > > * procfs/main.c (argp_parser): Proper error handling. > (argp_parser): Fix typo. Applied

Re: [PATCH] gnumach/device/ds_routines.h (device_pager_setup): add a function prototype

2013-06-29 Thread Samuel Thibault
Marin Ramesa, le Sat 29 Jun 2013 21:57:08 +0200, a écrit : > so I will move onto nontrivial improvements (hopefully). Good, thanks for this! Samuel

Re: [PATCH] gnumach/device/ds_routines.h (device_pager_setup): add a function prototype

2013-06-29 Thread Marin Ramesa
On 29.06.2013 20:48:59, Samuel Thibault wrote: > Marin Ramesa, le Fri 28 Jun 2013 20:04:19 +0200, a écrit : > > There is a function declared in dev_pager.c, used in ds_routines.c > > without a prototype. > > Thanks. Could you take the habit of writing the ChangeLog entry? > > Samuel > Sure. W

Re: [PATCH] tmpfs: fix parsing of fsys_set_options requests

2013-06-29 Thread Samuel Thibault
Justus Winter, le Thu 27 Jun 2013 15:06:28 +0200, a écrit : > * tmpfs/tmpfs.c (runtime_argp): Use options as option list. Applied, thanks. Samuel

Re: [PATCH] gnumach/kern/slab.c (slab_info): fix format warnings

2013-06-29 Thread Samuel Thibault
Marin Ramesa, le Fri 28 Jun 2013 11:16:38 +0200, a écrit : > A simple fix of printf format; vm_size_t is type defined as an unsigned > int. That may change for a 64bit port, but in the meanwhile, thanks. Samuel

Re: [PATCH 2/4] sutils: fix file_name_lookup_carefully

2013-06-29 Thread Samuel Thibault
Justus Winter, le Fri 28 Jun 2013 18:46:04 +0200, a écrit : > Fix the callback by dropping the test for a passive translator. It makes sense to me, I have commited it. Samuel

Re: [PATCH 1/4] mount: add -n and --no-mtab arguments

2013-06-29 Thread Samuel Thibault
Justus Winter, le Fri 28 Jun 2013 18:46:03 +0200, a écrit : > Add -n and --no-mtab arguments. As we do not write an mtab file, this > is a trivial patch that just ignores this argument to be more > compatible with Linux mount. I don't know whether we want to commit this upstream. Is being compati

Re: [PATCH] gnumach/device/ds_routines.h (device_pager_setup): add a function prototype

2013-06-29 Thread Samuel Thibault
Marin Ramesa, le Fri 28 Jun 2013 20:04:19 +0200, a écrit : > There is a function declared in dev_pager.c, used in ds_routines.c > without a prototype. Thanks. Could you take the habit of writing the ChangeLog entry? Samuel

Re: [PATCH] gnumach/device/net_io.h: add function prototypes

2013-06-29 Thread Samuel Thibault
Marin Ramesa, le Sat 29 Jun 2013 10:16:45 +0200, a écrit : > Tell the compiler that it will find these at link time; this fixes the > implicit declaration warnings. Thanks, I have just turned these: > +extern unsigned long int ntohl(unsigned long int); > +extern unsigned long int htonl(u

Re: [PATCH] gnumach/device/net_io.c (bpf_hash): expect unsigned long pointer type

2013-06-29 Thread Samuel Thibault
Hello, Marin Ramesa, le Sat 29 Jun 2013 16:23:30 +0200, a écrit : > Sometimes, bpf_hash gets arguments passed from incompatible pointer > types. This patch fixes this warning. I have actually commited the contrary: this is old code, which assumes "long" is 32bit, and wouldn't expect it to become

[PATCH] gnumach/device/net_io.c (bpf_hash): expect unsigned long pointer type

2013-06-29 Thread Marin Ramesa
Sometimes, bpf_hash gets arguments passed from incompatible pointer types. This patch fixes this warning. --- ./gnumach/device/net_io.c 2013-06-28 10:10:49.877024364 +0200 +++ ./gnumach1/device/net_io.c 2013-06-29 15:02:43.758232365 +0200 @@ -310,7 +310,7 @@ #define N_NET_HASH 4 #define N_

[PATCH] gnumach/device/net_io.h: add function prototypes

2013-06-29 Thread Marin Ramesa
Tell the compiler that it will find these at link time; this fixes the implicit declaration warnings. --- ./gnumach/device/net_io.h 2013-06-28 10:10:49.877024364 +0200 +++ ./gnumach1/device/net_io.h 2013-06-29 09:42:58.498730719 +0200 @@ -83,4 +83,9 @@ #define net_kmsg_alloc() ((ipc_kmsg_t) kallo