On 04/28/2012 12:21 PM, Pino Toscano wrote:
> Alle venerdì 27 aprile 2012, Roland McGrath ha scritto:
>>> > > 2012-04-27 Pino Toscano
>>> > >
>>> > > * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set
>>> > > EINVAL for negative `n' or less than `ngids'.
>> >
>>
Hi,
attached there is a patch to make Mach's nanosleep() (used by Hurd) a
bit more POSIX compliant:
* check for validity of the `requested_time' parameter
* return EINTR when interrupted
* modify correctly the `remaining' parameter only when interrupted
Thanks,
--
Pino Toscano
mach: compliance
Alle sabato 10 dicembre 2011, Pino Toscano ha scritto:
> attached there is a patch to add some validation for parameters of
> Mach's nanosleep() (used by Hurd).
Disregard this patch -- I'll send a better one with more fixes for
nanosleep.
--
Pino Toscano
signature.asc
Description: This is a
Alle sabato 28 aprile 2012, Roland McGrath ha scritto:
> Compliance with what? Is there a standard that specifies ptsname_r?
It is a Linux-specific function is implemented by GNU libc and other
systems.
> We don't use implicit boolean coercions, we use (buf != NULL).
Noted.
> But unless there
Alle sabato 28 aprile 2012, Roland McGrath ha scritto:
> You can just use string_t and no need for the XXX comment.
Fixed. (I initially made my changes as less intrusive as possible.)
> libc code can use C99 freely these days, so use an inline
> initializing declaration rather than pre-declaring
Alle venerdì 27 aprile 2012, Roland McGrath ha scritto:
> > 2012-04-27 Pino Toscano
> >
> > * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set
> > EINVAL for negative `n' or less than `ngids'.
>
> The norm is to use all caps and no quotes to mention local variable
> names
