Compliance with what? Is there a standard that specifies ptsname_r?
We don't use implicit boolean coercions, we use (buf != NULL).
But unless there is a standard requiring that you diagnose a
null pointer argument somehow, then it's actually better that
it just crash.
Thanks,
Roland
You can just use string_t and no need for the XXX comment.
libc code can use C99 freely these days, so use an inline initializing
declaration rather than pre-declaring a new variable.
I don't think there's any need to iniitalize the result buffer. We trust
the RPC stubs to return a properly-te
> 2012-04-27 Pino Toscano
>
> * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set EINVAL
> for negative `n' or less than `ngids'.
The norm is to use all caps and no quotes to mention local variable
names. You can also drop the (function) when it's the only function
in
Hi,
attached there is a patch to fix few issues in Hurd's ptsname_r(),
mostly checking for more error conditions and making sure to set as
errno and return the proper values on error conditions.
Thanks,
--
Pino Toscano
hurd: compliance fixes for ptsname_r
ptsname_r on failure returns the valu
Hi,
attached there is a patch to fix few issues in Hurd's getlogin_r():
avoid a static buffer, and check for buffer shorter than necessary.
Thanks,
--
Pino Toscano
hurd: compliance fixes for getlogin_r
* do not make `login' static, as it would make getlogin_r no more reentrant
* fail with ERAN
Hi,
attached there is a patch to fix a couple of issues with Hurd's
getgroups(), namely when the requested number is < 0 or when it is > 0
but less than the actual number of groups that would be returned (this
case is handled by simply returning the first n groups, instead of
failing).
Thanks
Hi!
On Fri, 27 Apr 2012 08:55:32 +0200, Svante Signell wrote:
> What was the conclusion after you implemented getcontext/setcontext in
> assembly? Would it be possible to integrate into Hurd or not? I would
> like to summarize my patches to the debian-hurd or gnu-hurd mailing list
> before moving
