Re: [PATCH v2 4/4] fix common misspellings

2011-08-20 Thread Samuel Thibault
Jonathan Neuschäfer, le Mon 15 Aug 2011 22:10:09 +0200, a écrit : > * Fix spelling with codespell[1] and manually review it. Applied, thanks. Samuel

Re: [PATCH v2 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

2011-08-20 Thread Jonathan Neuschäfer
On Sat, Aug 20, 2011 at 09:29:00AM -0700, Thomas Bushnell, BSG wrote: > I agree with Samuel. The use of NULL for pointers in C can lead people to > forget that C does not protect the types in this case. That's a valid argument and I didn't think of it this way. I just thought NULL would be clearer

Re: [PATCH v2 3/4] pfinet/linux-src: fix a memory leak

2011-08-20 Thread Samuel Thibault
Jonathan Neuschäfer, le Mon 15 Aug 2011 22:10:08 +0200, a écrit : > * pfinet/linux-src/net/ipv4/ip_options.c (ip_options_get): calculate >the size of opt only once, free opt before returning -EFAULT. > --- > pfinet/linux-src/net/ipv4/ip_options.c |9 ++--- > 1 files changed, 6 inserti

Re: [PATCH v2 2/4] fix a realloc-related memory leak in localhost()

2011-08-20 Thread Samuel Thibault
Jonathan Neuschäfer, le Mon 15 Aug 2011 22:10:07 +0200, a écrit : > * libshouldbeinlibc/localhost.c (localhost): assign the return value >of realloc to a temporary variable to avoid losing the old value of >buf in the case of realloc failing. Applied, thanks. Samuel

Re: [PATCH v2 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

2011-08-20 Thread Thomas Bushnell, BSG
I agree with Samuel. The use of NULL for pointers in C can lead people to forget that C does not protect the types in this case. Thomas On Sat, Aug 20, 2011 at 9:24 AM, Samuel Thibault wrote: > Jonathan Neuschäfer, le Mon 15 Aug 2011 22:10:06 +0200, a écrit : > > * ftpfs/host.c (split_server_na

Re: [PATCH v2 1/4] ftpfs/host.c: use NULL (instead of 0) for pointers

2011-08-20 Thread Samuel Thibault
Jonathan Neuschäfer, le Mon 15 Aug 2011 22:10:06 +0200, a écrit : > * ftpfs/host.c (split_server_name): assign NULL to *host, *user, and >*passwd instead of 0. Mmm, according to C, 0 is fine here, isn't it? Samuel

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Thomas Schmitt
Hi, i wrote: > > Does that mean i shall just try again with a new "disk" ? Samuel Thibault wrote: > Yes. Ok. I am getting a new netinst.iso now and plan to retry in the next days. > > Is there a way to mount the partitions of the "disk" in Linux, > > so i could read that grub.cfg ? Svante Sign

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Samuel Thibault
Svante Signell, le Sat 20 Aug 2011 17:07:29 +0200, a écrit : > On Sat, 2011-08-20 at 16:55 +0200, Samuel Thibault wrote: > > Svante Signell, le Sat 20 Aug 2011 16:54:21 +0200, a écrit : > > > losetup -o 1048576 /dev/loop0 hurd-test.img > > > mount -t ext2 /dev/loop0 /mnt > > > > You can also use >

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Svante Signell
On Sat, 2011-08-20 at 16:55 +0200, Samuel Thibault wrote: > Svante Signell, le Sat 20 Aug 2011 16:54:21 +0200, a écrit : > > losetup -o 1048576 /dev/loop0 hurd-test.img > > mount -t ext2 /dev/loop0 /mnt > > You can also use > > mount hurd-test.img -o offset=1048576 Nice, I assume you have to add

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Samuel Thibault
Svante Signell, le Sat 20 Aug 2011 16:54:21 +0200, a écrit : > losetup -o 1048576 /dev/loop0 hurd-test.img > mount -t ext2 /dev/loop0 /mnt You can also use mount hurd-test.img -o offset=1048576 Samuel

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Svante Signell
On Sat, 2011-08-20 at 16:36 +0200, Thomas Schmitt wrote: > There is no menu but only a GRUB prompt. > I have to confess that i am quite clueless with GRUB commands. > ls says: > (hd0) (hd0,msdos5) (hd0,msdos1) > What i read in the Debian GNU/Linux grub.cfg does not give me ideas. > Is there a way

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Samuel Thibault
Thomas Schmitt, le Sat 20 Aug 2011 16:36:53 +0200, a écrit : > Samuel Thibault wrote: > > Ah, that's a known bug with GRUB which has been fixed since then. > > Does that mean i shall just try again with a new "disk" ? Yes. > Or shall i get a new > http://people.debian.org/~sthibault/hurd-i386

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Thomas Schmitt
Hi, Samuel Thibault wrote: > Ah, that's a known bug with GRUB which has been fixed since then. Does that mean i shall just try again with a new "disk" ? Or shall i get a new http://people.debian.org/~sthibault/hurd-i386/installer/cdimage/netinst.iso first ? --

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Samuel Thibault
Svante Signell, le Sat 20 Aug 2011 15:32:56 +0200, a écrit : > > I can still see the successful kvm runs of yesterday with that option > > (SSH session from not rebooted workstation). > > This was the first reboot after apt-get install qemu-kvm . > > Without that option i get to the GRUB prompt ag

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Svante Signell
On Sat, 2011-08-20 at 15:11 +0200, Thomas Schmitt wrote: > Hi, > > I Samuel Thibault's thread 'cdrom interface?' i wrote: > > > Well, i am a bit embarassed that i failed to get Debian/Hurd running > > > on qemu-kvm of a Debian/Linux squeeze. It installs but then does not > > > boot. Other things k

Re: My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Samuel Thibault
Thomas Schmitt, le Sat 20 Aug 2011 15:11:24 +0200, a écrit : > This menu has an option to boot from the first disk. > I did, but this only yields a GRUB prompt. Ah, that's a known bug with GRUB which has been fixed since then. > Very strangely, next day, after rebooting the hosting GNU/Linux, i g

My failure to install Hurd on Debian GNU/Linux kvm

2011-08-20 Thread Thomas Schmitt
Hi, I Samuel Thibault's thread 'cdrom interface?' i wrote: > > Well, i am a bit embarassed that i failed to get Debian/Hurd running > > on qemu-kvm of a Debian/Linux squeeze. It installs but then does not > > boot. Other things kept me from re-trying and then asking for help. Samuel Thibault wrot

Re: cdrom interface?

2011-08-20 Thread Samuel Thibault
Thomas Schmitt, le Sat 20 Aug 2011 08:28:22 +0200, a écrit : > Well, i am a bit embarassed that i failed to get Debian/Hurd running > on qemu-kvm of a Debian/Linux squeeze. It installs but then does not > boot. Other things kept me from re-trying and then asking for help. Don't hesitate to ask. I'