Re: DDE - Commit fb489ff causes FTBFS

At Thu, 30 Jun 2011 13:53:27 +0200, Samuel Thibault wrote: > > Svante Signell, le Thu 30 Jun 2011 12:10:44 +0200, a écrit : > > On Wed, 2011-06-29 at 20:06 -0400, Stephen Gilles wrote: > > > I had been trying to build DDE packages for Arch Hurd for a while, and > > > aft> > Nice to see that DDE i

Re: Released the QotH 2011-q2 to the wiki: please proofread!

Arne Babenhauserheide skribis: > At Fri, 01 Jul 2011 11:33:37 +0200, > Svante Signell wrote: >> >> Change freekbsd to kFreeBSD, I think that is the official abbreviation. > > Fixed, thanks! The OS name is GNU/kFreeBSD, though. Ludo’.

Re: [PATCH 00/15] Hurd signals: please review

Hello, Jeremie Koenig, le Wed 29 Jun 2011 18:30:12 +0200, a écrit : > I believe my signal-related series of patches for Hurd are mature enough > to be reviewed and considered for inclusion. This looks quite good indeed. Roland, I'd like to apply the patch series to the Debian package to get more

Re: [PATCH 14/15] Hurd signals: SA_SIGINFO support

I believe this is good enough for an initial implementation. Jeremie Koenig, le Wed 29 Jun 2011 18:30:26 +0200, a écrit : > + uc->uc_sigmask = sc->sc_mask; > + uc->uc_stack.ss_sp = (__ptr_t) sc->sc_esp; > + uc->uc_stack.ss_size = 0; > + uc->uc_stack.ss_flags = 0; We generally don't know much

Re: [PATCH 12/15] Hurd signals: fix global untraced signals.

Jeremie Koenig, le Wed 29 Jun 2011 18:30:24 +0200, a écrit : > Delivering global signals by making them temporarily pending in the > global mask looses their untracedness status, so we need to deliver them > directly whenever we can. Agreed, I believe the patch is correct. The same loop could per

Re: [PATCH 13/15] Hurd signals: Copy bits/sigaction.h

Jeremie Koenig, le Wed 29 Jun 2011 18:30:25 +0200, a écrit : > * sysdeps/mach/hurd/bits/sigaction.h: New file, start with a copy of > bits/sigaction.h. Mmm, Roland, since we are using the BSD value for SA_SIGINFO, can't we simply add it to the main sigaction.h? +# define SA_SIGINFO0x0040 /*

Re: [PATCH 11/15] Hurd signals: fix sigwait() for global signals

Jeremie Koenig, le Wed 29 Jun 2011 18:30:23 +0200, a écrit : > * sysdeps/mach/hurd/sigwait.c (__sigwait): Change the blocking mask > temporarily so that we catch global as well as thread-specific signals. Mmm, this is unsafe: if yet another signal arrives between the setjmp return and locking ss,

Re: [PATCH 10/15] Hurd signals: provide a sigstate destructor

Jeremie Koenig, le Wed 29 Jun 2011 18:30:22 +0200, a écrit : > We can no longer afford to keep stale sigstate structures in the > _hurd_sigstates list if some of them are marked as global receivers, > otherwise we might try to use them to deliver signals. Agreed, I believe it is correct. Samuel

Re: [PATCH 09/15] Hurd signals: implement global signal dispositions

Jeremie Koenig, le Wed 29 Jun 2011 18:30:21 +0200, a écrit : > Currently each thread has a full "sigstate" structure which keeps track > of the signal dispositions, blocking mask and pending signals for this > thread. Process-wide signals are delivered to the main thread. > > However, the semantic

Re: [PATCH 08/15] Versions.def: add GLIBC_2.15

Jeremie Koenig, le Wed 29 Jun 2011 18:30:20 +0200, a écrit : > * Versions.def: add GLIBC_2.15 Trivial. Samuel

Re: [PATCH 06/15] Hurd signals: make sigsuspend POSIX-conformant.

Jeremie Koenig, le Wed 29 Jun 2011 18:30:18 +0200, a écrit : > * hurd/hurdsig.c (wake_sigsuspend): New function. > (post_signal): wake up sigsuspend calls in the "handle" case. > (post_signals): no longer wake up sigsuspend calls indiscriminately. Indeed, I believe this is correct: before, merely

Re: [PATCH 05/15] Hurd signals: reindent

Jeremie Koenig, le Wed 29 Jun 2011 18:30:17 +0200, a écrit : > * hurd/hurdsig.c (post_pending): reindent. This is trivially correct. Samuel

Re: [PATCH 04/15] Hurd signals: refactor check_pending_signals

Jeremie Koenig, le Wed 29 Jun 2011 18:30:16 +0200, a écrit : > * hurd/hurdsig.c (check_pending_signals): Split into pending_signals, > post_pending and post_all_pending_signals. > (_hurd_internal_post_signal): Handle the distinction between poll > requests and real signals there. I believe it is c

Re: [PATCH 03/15] _hurd_internal_post_signal: Split out inner functions

Jeremie Koenig, le Wed 29 Jun 2011 18:30:15 +0200, a écrit : > By having post_signal and check_pending_signal as top-level functions, > the way they communicate with the outside is made more transparent. I believe it is correct. Samuel

Re: [PATCH 02/15] _hurd_internal_post_signal: Scope variables more restrictively

Jeremie Koenig, le Wed 29 Jun 2011 18:30:14 +0200, a écrit : > * hurd/hurdsig.c (_hurd_internal_post_signal): Move the variable declarations > into the first-level inner functions which actually use them. I believe it is correct. Samuel

Re: [PATCH 07/15] Hurd signals: fix uninitialized value.

Jeremie Koenig, le Wed 29 Jun 2011 18:30:19 +0200, a écrit : > * hurd/hurdsig.c (post_signal): Don't call resume() with ACT uninitialized, > as it might result in the target thread being left suspended. Agreed, and is independant from the rest, and can be applied already. Samuel

Re: [PATCH 01/15] _hurd_internal_post_signal: Split into more functions

Jeremie Koenig, le Wed 29 Jun 2011 18:30:13 +0200, a écrit : > * hurd/hurdsig.c (_hurd_internal_post_signal): Use inner functions > instead of gotos for the overall flow control. > > This patch should change nothing besides replacing gotos with function > calls and return statements. I believe th