Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Samuel Thibault
Carl Fredrik Hammar, le Tue 29 Dec 2009 23:40:21 +0100, a écrit : > On Tue, Dec 29, 2009 at 11:10:00PM +0100, Samuel Thibault wrote: > > > > That's the same. To make it clearer, see attached patch. > > I meant in the other branch of the if (though for some reason I didn't > consider the server p

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Carl Fredrik Hammar
On Tue, Dec 29, 2009 at 11:10:00PM +0100, Samuel Thibault wrote: > > That's the same. To make it clearer, see attached patch. I meant in the other branch of the if (though for some reason I didn't consider the server part's if). Patch attatched for clarity. Regards, Fredrik diff --git a/auth

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Samuel Thibault
Samuel Thibault, le Tue 29 Dec 2009 23:34:08 +0100, a écrit : > > OK, I can use that for the client side. I don't really have a setup > > for testing the auth server though. Do you use a sub-Hurd or something? > > I've never managed to find time to set up a sub-hurd, so I just debug > with write

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Samuel Thibault
Carl Fredrik Hammar, le Tue 29 Dec 2009 23:29:35 +0100, a écrit : > On Tue, Dec 29, 2009 at 10:55:41PM +0100, Samuel Thibault wrote: > > Carl Fredrik Hammar, le Tue 29 Dec 2009 22:48:26 +0100, a écrit : > > > It's still a mystery to me why ext2fs gets an EINTR without auth > > > explicitly returnin

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Carl Fredrik Hammar
On Tue, Dec 29, 2009 at 10:55:41PM +0100, Samuel Thibault wrote: > Carl Fredrik Hammar, le Tue 29 Dec 2009 22:48:26 +0100, a écrit : > > It's still a mystery to me why ext2fs gets an EINTR without auth > > explicitly returning EINTR... > > AIUI, the RPC gets aborted and ext2fs receives MACH_RCV_PO

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Samuel Thibault
Carl Fredrik Hammar, le Tue 29 Dec 2009 23:01:06 +0100, a écrit : > On Mon, Dec 28, 2009 at 03:24:52AM +0100, Samuel Thibault wrote: > > Carl Fredrik Hammar, le Sun 27 Dec 2009 20:56:21 +0100, a écrit : > > > If the notification request is canceled before auth_user_authenticate > > > returns there

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Carl Fredrik Hammar
On Mon, Dec 28, 2009 at 03:24:52AM +0100, Samuel Thibault wrote: > Carl Fredrik Hammar, le Sun 27 Dec 2009 20:56:21 +0100, a écrit : > > If the notification request is canceled before auth_user_authenticate > > returns there should be no problem. > > I tried a crude > > error_t err2 = m

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Samuel Thibault
Carl Fredrik Hammar, le Tue 29 Dec 2009 22:48:26 +0100, a écrit : > It's still a mystery to me why ext2fs gets an EINTR without auth > explicitly returning EINTR... AIUI, the RPC gets aborted and ext2fs receives MACH_RCV_PORT_DIED, which _hurd_intr_rpc_mach_msg turns into EINTR. BTW, reproducing

Re: Reauthentication implementation flaw due to EINTR

2009-12-29 Thread Carl Fredrik Hammar
Hi, On Mon, Dec 28, 2009 at 03:43:47AM +0100, Samuel Thibault wrote: > Carl Fredrik Hammar, le Sun 27 Dec 2009 22:24:24 +0100, a écrit : > > OK, I think I have a vague picture of what is going on: > > ports_interrupt_self_on_port_death > > ports_interrupt_self_on_notification > > ports_interrupt_r

Re: hurd/trans/hello.c changes

2009-12-29 Thread Shakthi Kannan
Hi, --- On Mon, Dec 28, 2009 at 4:13 AM, wrote: | I guess the hurd/ prefix is not necessary when building in-tree. As I | already said on IRC, the file was never meant to be compiled standalone. \-- Ok. --- | But perhaps it still works with the Prefix even in-tree... Could you | test that? \--

Re: cannot boot subhurd

2009-12-29 Thread Da Zheng
On 09-12-29 下午5:42, olafbuddenha...@gmx.net wrote: > Hi, > > On Mon, Dec 28, 2009 at 11:45:50PM +0800, Da Zheng wrote: > >> I tried to boot subhurd but no matter how I try it, it just fails to >> boot. > >> #boot servers.boot /dev/hd1 > > Err... /dev/hd1? That's almost certainly wrong. You want

Re: cannot boot subhurd

2009-12-29 Thread olafBuddenhagen
Hi, On Mon, Dec 28, 2009 at 11:45:50PM +0800, Da Zheng wrote: > I tried to boot subhurd but no matter how I try it, it just fails to > boot. > #boot servers.boot /dev/hd1 Err... /dev/hd1? That's almost certainly wrong. You want to boot from a partition, not from a drive... (I guess some kind o