Re: Some questions about libports and notification of ports

2008-08-20 Thread Thomas Bushnell BSG
On Wed, 2008-08-20 at 22:47 +0200, zhengda wrote: > I want to get the confirmation from you about the usage of > ports_get_right(), ports_destroy_right() and ports_port_deref(). > When I use ports_get_right() to get the receive right of the port, I > should always make a send right for the port.

Re: dir_lookup, locking and EINTR

2008-08-20 Thread Thomas Bushnell BSG
On Thu, 2008-08-21 at 00:39 +0100, Samuel Thibault wrote: > That's safer indeed. To make things simpler, the patch below just > systematically resets NEWPI and NEWPO to NULL as soon as they don't need > to be dereferenced, does it look ok? It does, but "NULL" is entirely unnecessary. I much pref

Re: The patch of boot to open a virtual network interface

2008-08-20 Thread Ben Asselstine
On Tue, Aug 19, 2008 at 4:02 PM, zhengda <[EMAIL PROTECTED]> wrote: > > +case 'f': > + dev_file = strstr (arg, "="); > + if (dev_file == NULL) > + return ARGP_ERR_UNKNOWN; > + *dev_file = 0; > + add_dev_map (arg, dev_file+1); > + break; I'd feel better about this

Re: dir_lookup, locking and EINTR

2008-08-20 Thread Samuel Thibault
Thomas Bushnell BSG, le Tue 19 Aug 2008 23:09:56 -0700, a écrit : > Your patch (which I see has been applied) seems to be clearly the Wrong > Thing in the case where NP == DNP. Aow right. > The right thing to do is to throw NEWPI away at the very end of the > function. That's safer indeed. To m

Some questions about libports and notification of ports

2008-08-20 Thread zhengda
Hello everyone, I want to get the confirmation from you about the usage of ports_get_right(), ports_destroy_right() and ports_port_deref(). When I use ports_get_right() to get the receive right of the port, I should always make a send right for the port. So if we just want to get the name of t