Aren't spinlocks missing a memory clobber? [Was: ext2fs crashes lately]

2008-08-01 Thread Samuel Thibault
Barry deFreese, le Thu 24 Jul 2008 22:19:16 -0400, a écrit : > ext2fs.static: > /var/tmp/hurd-20071119/build-tree/hurd/libports/port-ref.c:31:ports_port_ref: > Assertion 'pi->refcnt || pi->weakrefcnt' failed. Quite odd. I had a closer look at the locking functions, and I noticed that spin_*lock

Re: [PATCH] libfshelp: keep stdin and stdout open

2008-08-01 Thread Roland McGrath
> I'd agree on the principle to not leave a nul port for stdin/stdout, > any other opinion on this? I don't think this is good "on principle". If there is a principle, it's that programs should be robust and not assume anything stupid like that fds 0,1 are already open if that's not part of the c

Re: [PATCH] libfshelp: keep stdin and stdout open

2008-08-01 Thread Samuel Thibault
Hello, I'd agree on the principle to not leave a nul port for stdin/stdout, any other opinion on this? Samuel