Hey,
Thanks for the comments.
> - take care of indentation. Try to respect the same existing indentation
> (yes it's not homogeneous, follow it per-file). For instance, in
> new-gnumach-3/i386/i386at/model_dep.c
Ah, sorry. My emacs automatically reindents every file to my settings,
I'll disable
Hello,
I haven't reviewed db_elf.c itself, thus not replying on the tracker.
It generally looks good (I've commited the symbol_values already), just
a few points:
- take care of indentation. Try to respect the same existing indentation
(yes it's not homogeneous, follow it per-file). For instan
Hello,
It's quite common to see code that calls test -x to check whether the x
bit was disabled on a file, before trying to execute it.
That does not work on the Hurd for uid 0:
# touch foo
# ls -l foo
-rw-r--r-- 1 root root 0 May 24 21:31 foo
# [ -x foo ] && echo erf
erf
# ./foo
-bash: ./foo: P
