Re: bugs in idvec-verify.c, almost...

2003-09-07 Thread Roland McGrath
> > if (getpwuid_r (id, &_pw, id_lookup_buf, sizeof id_lookup_buf, &pw) > > == 0) > > That code is ugly anyway, we should do function calls outside of if > conditions. So this could be cleaned up along with the semantic fix. There is nothing wrong with this kind of conditional. _

Re: bugs in idvec-verify.c, almost...

2003-09-07 Thread Marcus Brinkmann
On Sat, Sep 06, 2003 at 03:40:34PM -0400, Roland McGrath wrote: > > > if (getpwuid_r (id, &_pw, id_lookup_buf, sizeof id_lookup_buf, &pw) > > > == 0) > > > > That code is ugly anyway, we should do function calls outside of if > > conditions. So this could be cleaned up along with the semant

Re: fifo, mmap, errors [better patch]

2003-09-07 Thread Roland McGrath
> +2003-09-05 Greg Buchholz <[EMAIL PROTECTED]> Standard form is to include ChangeLog fragments as plain text before your patch, not as part of the patch. Please do that in future. > + * tunnel.c (trivfs_S_io_map): Changed return value to EOPNOTSUPP Punctuate sentences. > diff -bBrw -U2