Re: [PATCH] Makeconf: controlling the optimization level

2001-04-15 Thread Roland McGrath
> This is necessary as gcc selects the highest flags thus: > > # CFLAGS=-O make > > would be overridden by the default value in CFLAGS. This is not true. GCC always uses the last -O argument, overriding the earlier ones. In -v, you'll see they're all passed through to cc1. cc1 uses the

Re: memory leak in dir-lookup found

2001-04-15 Thread Roland McGrath
> I disagree, if we set *USER to NULL on failure, we get the same effect. Ok. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd

Re: [PATCH] libdiskfs: bugs

2001-04-15 Thread Roland McGrath
> * dir-chg.c (disk_S_dir_notice_changes): Check the return of malloc. Your actual patch removes the check that was already there. > * file-set-trans.c (diskfs_S_file_set_translator): Be > consistent, use err not error. Please do not make this sort of gratuitous change. There

Re: [PATCH] tmpfs: now working

2001-04-15 Thread Roland McGrath
Thanks very much for working on this. > * tmpfs.c (main): Do not deallocate the underlying node; > servers deallocate nodes based only on the number of outstanding > protids. What is this supposed to be about? There is no protocol requirement that a filesystem keep a send rig

[DOC] Manually Bootstraping a Translator

2001-04-15 Thread Neal H Walfield
As this might be useful to someone else, here is how to manually bootstrap a translator. Manually Bootstrapping a Translator === The most common way to start a translator is to use the `settrans' command. It provides a flag, `-P', which waits until the user press

[PATCH] libdiskfs: bugs

2001-04-15 Thread Neal H Walfield
2001-04-14 Neal H Walfield <[EMAIL PROTECTED]> * node-create.c (diskfs_create_node): If we fail, set *NEWNODE to NULL; at least diskfs_S_dir_lookup depends on this behavior. * dir-chg.c (disk_S_dir_notice_changes): Check the return of malloc. * file-set

[PATCH] tmpfs: now working

2001-04-15 Thread Neal H Walfield
This patch makes tmpfs work. Well, mostly. If you attempt to create files too quickly on the tmpfs (e.g. extract a tar file), vm_map (when passed memory objects, it works fine mapping anonymously) maps bad memory regions into the server address space which cause the server to stall during the me

Re: memory leak in dir-lookup found

2001-04-15 Thread Neal H Walfield
On Sun, Apr 01, 2001 at 05:47:39PM -0400, Roland McGrath wrote: > > I have added several convenience function and revised the source > > appropriately. It also uses a new calling convention making > > not checking for errors difficult, however, this is at the cost > > of ABI incompatibility, howe

Re: learning MIG

2001-04-15 Thread Neal H Walfield
On Thu, Apr 12, 2001 at 05:17:16PM +0200, Gibran Hasnaoui wrote: > Ok, > > So the good way would be to make a translator, after > I use my .defs and implement foo() in the translator. > Then I can use a client which speek with the translator. > > That's it ? :) It is not quite that easy. You

[PATCH] Makeconf: controlling the optimization level

2001-04-15 Thread Neal H Walfield
This patch adds a variable, COPTIMIZE, to Makeconf. This allows the user to easily control the level of optimization for a single file or a single module. For example: # cd libdiskfs # COPTIMIZE= make would build libdiskfs with minimal optimizations thus not eliminating variabl

Re: [PATCH] New function (libfshelp) fshelp_cancontrol

2001-04-15 Thread Roland McGrath
> > I'd like to have this same single checking function used for all the > > control-the-world permission checks. This includes all the "isroot" > > settings used in trivfs and term and so forth, and also the more detailed > > checks in things like chown. In keeping with fshelp_isowner, it might

Re: [PATCH] proc: cleanup

2001-04-15 Thread Roland McGrath
Thanks, I've applied these changes. In future, please refrain from gratuitous editting of comments. Fixing typos or errors is a good thing, and changing comments to be more informative is fine. But trivial changes to punctuation and phraseology don't really add anything and they clutter up your