Re: version-etc not working with autoconf 2.61

2009-11-25 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 11/22/2009 1:57 AM: >> Thanks for the patch. >> How about the following instead? >> Then, if some package is defining PACKAGE specially >> and expecting that value to be used here, it will still appear. > > I'd say go ahead and commit this. Done.

Re: version-etc not working with autoconf 2.61

2009-11-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/22/2009 1:57 AM: > Thanks for the patch. > How about the following instead? > Then, if some package is defining PACKAGE specially > and expecting that value to be used here, it will still appear. I'd say go ahead and co

Re: version-etc not working with autoconf 2.61

2009-11-24 Thread Andy Wingo
On Sun 22 Nov 2009 09:57, Jim Meyering writes: > Thanks for the patch. > How about the following instead? > Then, if some package is defining PACKAGE specially > and expecting that value to be used here, it will still appear. Thanks for the fix. I knew that something wasn't right :) We'll test

Re: version-etc not working with autoconf 2.61

2009-11-22 Thread Jim Meyering
Andy Wingo wrote: > I just applied this to Guile. Perhaps something like it should go into > Gnulib? ... > diff --git a/lib/version-etc.c b/lib/version-etc.c > index 4f9de48..a7be46e 100644 > --- a/lib/version-etc.c > +++ b/lib/version-etc.c > @@ -245,7 +245,7 @@ emit_bug_reporting_address (void) >

Re: version-etc not working with autoconf 2.61

2009-11-21 Thread Bruno Haible
Eric Blake asked: > Gnulib pre-assumes that you are using Automake, and automake generally > guarantees that PACKAGE is defined. What is guile doing that violates > this assumption? guile's configure.ac is invoking AM_INIT_AUTOMAKE([... no-define ...]) which has the effect that PACKAGE and VERS

Re: version-etc not working with autoconf 2.61

2009-11-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Andy Wingo on 11/21/2009 10:59 AM: > Hello, > > I just applied this to Guile. Perhaps something like it should go into > Gnulib? Gnulib pre-assumes that you are using Automake, and automake generally guarantees that PACKAGE is defined.

version-etc not working with autoconf 2.61

2009-11-21 Thread Andy Wingo
Hello, I just applied this to Guile. Perhaps something like it should go into Gnulib? Cheers, Andy commit 624c5c7c8870baf610785a821e8bb40d41db2051 Author: Andy Wingo Date: Fri Nov 20 17:24:40 2009 +0100 fix version-etc for older autoconf * lib/version-etc.c: Don't reference the