Re: test-openat-safer failure on older kernel

2009-09-05 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/5/2009 9:29 AM: >> an empty argument to openat, which is why my test-openat-safer was the >> first thing to catch this in nearly 3 years of use. >> +openat: fail with ENOENT on empty name >> +* lib/openat-proc.c (

Re: test-openat-safer failure on older kernel

2009-09-05 Thread Jim Meyering
Eric Blake wrote: > On on older machine (2.6.16.29 kernel, glibc 3.4.6), when using /proc > emulation, openat(fd,"",O_RDONLY) was accidentally succeeding in opening a > copy of /proc/self/fd/n (ie. the directory pointed to by fd) instead of > failing with ENOENT. Fixed as follows. Fortunately, in

test-openat-safer failure on older kernel

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On on older machine (2.6.16.29 kernel, glibc 3.4.6), when using /proc emulation, openat(fd,"",O_RDONLY) was accidentally succeeding in opening a copy of /proc/self/fd/n (ie. the directory pointed to by fd) instead of failing with ENOENT. Fixed as foll