Re: sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Karl Berry
Done. Thanks. > And ideally put a note in gitlog-to-changelog saying as much? Not done. I don't think it requires a comment. It's quite obvious that when someone uses sorting at such a place, it's to guarantee reproducibility. Agreed. I didn't mean that (sorry for not being cle

Re: sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Bruno Haible
Karl Berry wrote: > Thanks. So can you please install these gnulib changes? Done. > And ideally put a note in gitlog-to-changelog saying as much? Not done. I don't think it requires a comment. It's quite obvious that when someone uses sorting at such a place, it's to guarantee reproducibility.

Re: sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Karl Berry
but it seems that here the sort criterion does not really matter? Indeed, I think the default (ASCII byte) sort is fine here. gitlog-to-changelog is maintained in Gnulib, as can be seen from $ git log build-aux/gitlog-to-changelog Thanks. So can you please install these gnulib cha

Re: sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Collin Funk
Hi Karl, On 6/13/24 7:23 AM, Karl Berry wrote: > And, where is the latter maintained? The script itself does not say, and > it's copied around everywhere. I could figure it out eventually, but > in the interests of time, thought I'd just ask ... --thanks, karl. I can't comment on the change since

Re: sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Bruno Haible
Hi Karl, > The patch included tweaks to gendocs.sh and gitlog-to-changelog, below. > I'm working on the automake parts of the patch, but can someone here > decide about committing them please? To me (who doesn't know Perl) they look reasonable. Perl's sort allows to specify the sort criterion (<

sort keys patch for gendocs.sh, gitlog-to-changelog

2024-06-13 Thread Karl Berry
We received a report in Automake about sorting hash keys in Perl (ca.2017). https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25629 The patch included tweaks to gendocs.sh and gitlog-to-changelog, below. I'm working on the automake parts of the patch, but can someone here decide about committing them