Bruno Haible writes:
> Please consider the boolean value of these expressions.
> - Unix: I wish the signature check to be enabled.
> - Cygwin: likewise
> - 64-bit Windows: here it can be enabled as well.
> - 32-bit Windows: here not. This is the case we need to exclude.
Oops, that is emb
Hi Collin,
> > But should this condition
> >
> > #if defined _WIN64 && !defined __CYGWIN__
> >
> > not better be
> >
> > #if !(defined _WIN32 && !defined _WIN64 && !defined __CYGWIN__)
> >
> > ?
> ...
> So either would work I believe.
Please consider the boolean value of these expressions.
Hi Bruno,
Bruno Haible writes:
> But should this condition
>
> #if defined _WIN64 && !defined __CYGWIN__
>
> not better be
>
> #if !(defined _WIN32 && !defined _WIN64 && !defined __CYGWIN__)
>
> ?
Good question. I wasn't exactly sure how _WIN32 and _WIN64 were defined
and copied the conditi
Hi Collin,
> I have chosen the lazy option and just disabled the tests. From my quick
> search I don't see it used as a function pointer and 32-bit Windows
> doesn't seem worth the effort.
>
> Pushed the attached patch to disable the tests there and document the
> declaration.
Thanks. This will
Hi Bruno,
Bruno Haible writes:
> It's a matter of effort. Disabling the signature test means that code that
> uses the function via a function pointer (as opposed to direct invocation)
> may run into trouble. Whereas enabling it forces you to fix that case as well,
> at the cost of more code in
Collin Funk wrote:
> Now all tests pass except for MSVC (32). The error I see there is:
>
> D:\a\ci-scratch\ci-scratch\testdir1\gltests\test-servent.c(25): error
> C2440: 'initializing': cannot convert from 'servent *(__stdcall *)(const char
> *,const char *)' to 'servent *(__cdecl *)(const
Hi Bruno,
Bruno Haible writes:
> Yes. You can, for example, use your GitHub ci-scratch repository to
> collect the data about various OSes in their current version, and
> condense a unit test from that. Then commit that, and we can work
> out the situation on AIX, Haiku, and older OS versions af
Collin Funk wrote:
> Though, in practice I believe every OS (unsure about Windows) uses
> /etc/services. So maybe it is best to just assume it will work normally
> and improve the tests.
Yes. You can, for example, use your GitHub ci-scratch repository to
collect the data about various OSes in thei
Forgot to add attachment...
>From e9c1d94f58eaacee919bb2015da490b980a5eedf Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Mon, 30 Dec 2024 19:00:01 -0800
Subject: [PATCH] servent: Add tests.
* tests/test-servent.c: New file.
* modules/servent-tests: New file.
---
ChangeLog |
I added a simple test for the servent module. All it does is check that
the function prototypes of getservbyname and getservbyport are correct
and that the functions can be called. Therefore it will fail if
$(SERVENT_LIB) is set incorrectly.
POSIX says [1]:
This information [serivces] is cons
10 matches
Mail list logo
