Re: regex compile warnings

2006-07-29 Thread Larry Jones
Paul Eggert writes: > > I don't think so. I think that code is portable K&R C code, as well > as being portable C89 and C99 code, if the item being initialized is a > scalar. I agree, I think it's just a plain old compiler bug. Particularly since it apparently didn't object to the essentially s

Re: regex compile warnings

2006-07-29 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: >>> "../../lib/regexec.c", line 1412: warning: non-constant initializer: op "--" >> >> I don't understand this one. Here's the line in question: >> >> Idx num = --fs->num; >> >> and I assume Idx is size_t, which is a 32-bit unsigned integer, so this >>

Re: regex compile warnings

2006-07-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 7/28/2006 5:48 PM: >> >> "../../lib/regex_internal.h", line 714: warning: token-less macro argument > > This one is worth fixing, since the code does not conform to C89. Fix checked in. >> "../../lib/regexec.c", line 1412

Re: regex compile warnings

2006-07-28 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Is it worth silencing these compiler warnings with /usr/ucb/cc on Solaris 7? > > "../../lib/regex_internal.h", line 714: warning: token-less macro argument This one is worth fixing, since the code does not conform to C89. The obvious fix is to surround th

regex compile warnings

2006-07-28 Thread Eric Blake
Is it worth silencing these compiler warnings with /usr/ucb/cc on Solaris 7? "../../lib/regex_internal.h", line 714: warning: token-less macro argument "../../lib/regexec.c", line 1412: warning: non-constant initializer: op "--" -- Eric Blake