Re: recent argp changes

2007-05-02 Thread Ben Pfaff
Ben Pfaff <[EMAIL PROTECTED]> writes: > Paul Eggert <[EMAIL PROTECTED]> writes: > >> Bruno Haible <[EMAIL PROTECTED]> writes: >> >>> you are now assuming an in-place sorting algorithm. If a libc were >>> to implement qsort by use of mergesort (and temporary storage), such >>> a sorting algorithm w

Re: recent argp changes

2007-05-01 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> ha escrit: > - Add a field 'array_index' to the hol_entry struct. Fill these fields > right before calling qsort. Actually, that was my first idea, but the trick with pointers seemed easier:) I have rewritten it this way. Thank you. Regards, Sergey

Re: recent argp changes

2007-05-01 Thread Ben Pfaff
Paul Eggert <[EMAIL PROTECTED]> writes: > Bruno Haible <[EMAIL PROTECTED]> writes: > >> you are now assuming an in-place sorting algorithm. If a libc were >> to implement qsort by use of mergesort (and temporary storage), such >> a sorting algorithm would pass you two pointers to hol_entrys in >>

Re: recent argp changes

2007-05-01 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > you are now assuming an in-place sorting algorithm. If a libc were > to implement qsort by use of mergesort (and temporary storage), such > a sorting algorithm would pass you two pointers to hol_entrys in > different array. A minor quibble: the C standar

Re: recent argp changes

2007-05-01 Thread Ben Pfaff
Bruno Haible <[EMAIL PROTECTED]> writes: >> The option sorting in argp-help was based on the stability >> of sort algorithm, therefore the test failed on systems with >> quicksort qsort implementations. It went unnoticed on glibc, >> because its qsort uses adaptive algorithm, defaulting to >> ins

Re: recent argp changes

2007-05-01 Thread Bruno Haible
Hello Sergey, > The option sorting in argp-help was based on the stability > of sort algorithm, therefore the test failed on systems with > quicksort qsort implementations. It went unnoticed on glibc, > because its qsort uses adaptive algorithm, defaulting to > insertion sort if the number of par

Re: recent argp changes

2007-04-30 Thread Sergey Poznyakoff
Hello, The option sorting in argp-help was based on the stability of sort algorithm, therefore the test failed on systems with quicksort qsort implementations. It went unnoticed on glibc, because its qsort uses adaptive algorithm, defaulting to insertion sort if the number of partitions is smalle

Re: recent argp changes

2007-04-29 Thread Sergey Poznyakoff
Bruno Haible <[EMAIL PROTECTED]> ha escrit: > Did that, and also on a few other systems. There are now three problems: > 1) A compilation warning when using "gcc -Wall": [..] > 2) Test failure due to invalid options passed to "diff". That's my fault. I've used these changes in my local setup, an

recent argp changes

2007-04-29 Thread Bruno Haible
Hi Sergey, > I have made some changes to argp testsuite. Could you please re-run > the test on NetBSD? Did that, and also on a few other systems. There are now three problems: 1) A compilation warning when using "gcc -Wall": test-argp.c: In function `main': test-argp.c:458: warning: implicit