Re: openpty module broken on Solaris

2013-02-08 Thread Reuben Thomas
On 8 February 2013 16:09, Paul Eggert wrote: > Thanks for the diagnosis. I should have proofread the Jan 31 > openpty patch better. Reuben, if the openpty module is used, > application code should not inspect HAVE_OPENPTY to decide whether > to use openpty -- instead, the idea is that applicati

Re: openpty module broken on Solaris

2013-02-08 Thread Paul Eggert
Thanks for the diagnosis. I should have proofread the Jan 31 openpty patch better. Reuben, if the openpty module is used, application code should not inspect HAVE_OPENPTY to decide whether to use openpty -- instead, the idea is that application code can simply invoke openpty as if it were a GNU p

Re: openpty module broken on Solaris

2013-02-08 Thread Mats Erik Andersson
fredag den 8 februari 2013 klockan 10:01 skrev Mats Erik Andersson detta: > The change introduced in gnulib-9fd is broken > on OpenSolaris and Solaris 11. And OpenBSD. > The reason is that said patch erroneously leads > to a claim > >/* config.h */ ># define HAVE_OPENPTY 1 It seems

openpty module broken on Solaris

2013-02-08 Thread Mats Erik Andersson
The change introduced in gnulib-9fd is broken on OpenSolaris and Solaris 11. The reason is that said patch erroneously leads to a claim /* config.h */ # define HAVE_OPENPTY 1 This leads to an undefined linker reference in "openpty.o" and thus also in "libgnu.a". On behalf of GNU Inetu