Eric Blake wrote:
> According to Jim Meyering on 9/25/2009 5:59 AM:
>> When I see the tentacles of this change reaching so deeply into the core
>> of gnulib and coreutils, I have to question whether it is worthwhile
>> to accommodate mingw's lack of inode numbers.
>>
>> Opinions?
>
> Raise this iss
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/25/2009 5:59 AM:
> When I see the tentacles of this change reaching so deeply into the core
> of gnulib and coreutils, I have to question whether it is worthwhile
> to accommodate mingw's lack of inode numbers.
>
> Opini
Eric Blake wrote:
> According to Jim Meyering on 9/24/2009 12:29 AM:
>> bool same = false;
>> ...
>> same = SAME_INODE (source_dir_stats, dest_dir_stats);
>> if (same < 0)
>> same = (identical_basenames
>> && strcmp (source_basename, dest_basename) == 0);
>
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/24/2009 12:29 AM:
> bool same = false;
> ...
> same = SAME_INODE (source_dir_stats, dest_dir_stats);
> if (same < 0)
> same = (identical_basenames
> && strcmp (source_basename, dest
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/24/2009 12:29 AM:
>> I'm also preparing a followup patch for coreutils usage of SAME_INODE.
>> Thoughts before I apply this?
>
> You have pushed these changes already.
> Imagine my surprise upon seeing unreviewed and una
If the tri-state test is required in only a few places,
how about using a new macro, say SAME_INODE_TRISTATE,
I suggest SAME_INODE_STRICT, and agree in general with Jim's email.
Paolo
Eric Blake wrote:
> I'm currently testing these two patches, as mingw prerequisites before I can
> get linkat() working. In particular, mingw is lousy at SAME_INODE, since all
> three of [fl]stat produce st_ino == 0 for all files (then again, mingw never
> claimed POSIX compliance!). Code was alw
I'm currently testing these two patches, as mingw prerequisites before I can
get linkat() working. In particular, mingw is lousy at SAME_INODE, since all
three of [fl]stat produce st_ino == 0 for all files (then again, mingw never
claimed POSIX compliance!). Code was always taking the identica
