-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/6/2009 3:14 PM:
> Additionally, this patch fixes a bug: gl_FUNC_OPENAT did not AC_REQUIRE
> gl_OPENAT_DEFAULTS. So it could happen that gl_FUNC_OPENAT gets expanded
> before gl_UNISTD_H_DEFAULTS, and then the variable GNU
Eric Blake wrote:
> > OK to apply?
>
> Yes, please.
Applied and pushed.
Bruno
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/6/2009 3:14 PM:
> No, really, all macros needed for constructing the replacement
> are supposed to sit in m4/unistd_h.m4.
Good argument.
> Another plus is that it separates the blocks for different functions in
> unist
Eric Blake wrote:
> So we only need the
> AC_SUBST (provided by gl_OPENAT_DEFAULTS), not the AC_DEFINE (provided by
> gl_MODULE_INDICATOR). Yes, okay to make that change.
Done:
2009-09-06 Bruno Haible
* modules/openat (configure.ac): Remove unneeded witness.
--- modules/openat.orig
Eric Blake wrote:
> --- a/modules/unistd
> +++ b/modules/unistd
> @@ -4,6 +4,7 @@ A GNU-like .
> Files:
> m4/unistd_h.m4
> lib/unistd.in.h
> +m4/openat.m4
So every package that needs now needs to include a file named
openat.m4? It we had gone this route, the generation of would
now depend on
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 9/6/2009 2:22 PM:
> Eric Blake wrote:
>> configure.ac:
>> gl_FUNC_OPENAT
>> +gl_MODULE_INDICATOR([openat])
>
> This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C
> preprocessor macro anywhere in lib/,
Eric Blake wrote:
> configure.ac:
> gl_FUNC_OPENAT
> +gl_MODULE_INDICATOR([openat])
This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C
preprocessor macro anywhere in lib/, nor in coreutils. So I propose to
remove this unneeded witness.
Bruno
I'm adding this doc tweak and indentation fix:
2009-09-06 Bruno Haible
* doc/posix-headers/fcntl.texi (AT_*): Mention affected platforms.
* lib/sys_stat.in.h: Fix preprocessor command indentation.
--- doc/posix-headers/fcntl.texi.orig 2009-09-06 21:37:44.0 +0200
+++
Eric Blake byu.net> writes:
> > That brings up the lack of an faccessat replacement in gnulib.
>
> I'll post a module for this shortly.
It is feasible for a system to have faccessat but not euidaccess (if they are
complying strictly with POSIX 2008), so we might as well add that to our
euidac
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/3/2009 6:52 AM:
> I'm adjusting it to use faccessat with AT_EACCESS instead.
Ouch. Cygwin 1.7 has faccessat but not euidaccess, and it currently has
bugs (including no AT_EACCESS support, even though AT_EACCESS is defin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/3/2009 6:52 AM:
> But in the long run, we should provide a replacement function,
> as we do for all other *at functions.
In the *at family, gnulib is still missing:
faccessat
linkat
mknodat
mkfifoat
readlinkat
renameat
Eric Blake wrote:
> Jim, what do you think of this patch, making it possible to avoid
> including "openat.h" if you only use the POSIX 2008 interfaces?
That's definitely the right thing to do.
Thanks for working on this.
I haven't looked at it carefully yet, but already
your mention of AT_EACCESS
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Jim, what do you think of this patch, making it possible to avoid
including "openat.h" if you only use the POSIX 2008 interfaces?
- --
Don't work too hard, make some time for fun as well!
Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE--
13 matches
Mail list logo
