Re: maint.mk syntax check problems

Jim Meyering wrote: > Martin von Gagern wrote: > ... > 5. sc_prohibit_always-defined_macros reports missing files: > > The sc_prohibit_always-defined_macros check will cause error messages > about missing files to be emitted if elements from the gl_other_headers_ > list are not

Re: Syntax checks in perl (was: Re: maint.mk syntax check problems)

Hi Martin. On Thursday 15 September 2011, Martin von wrote: > On 15.09.2011 11:37, Jim Meyering wrote: > > I'm sure that a perl-based > > implementation would be far more efficient, and probably faster > > even if the perl implementation doesn't run its tests in parallel. > > > > Perl is well sui

Syntax checks in perl (was: Re: maint.mk syntax check problems)

On 15.09.2011 11:37, Jim Meyering wrote: > I'm sure that a perl-based > implementation would be far more efficient, and probably faster > even if the perl implementation doesn't run its tests in parallel. > > Perl is well suited to this task. > I'm sure some will object to Perl's syntax, but not I

Re: maint.mk syntax check problems

Stefano Lattarini wrote: ... >> Converting to a stand-alone script is a fine and seductive idea. > > About an yaer ago I had proposed a similar move for automake's own > maintainer checks; see this RFC patch: > At first gla

Re: maint.mk syntax check problems

Hi Jim. On Thursday 15 September 2011, Jim Meyering wrote: > Martin von Gagern wrote: > ... > >> It might not be worth the effort/disruption. > >> One advantage of using Makefile rules is that it's easy to override > >> the defaults, as you see in the examples above. > > > > Not so hard with shell

Re: maint.mk syntax check problems

Martin von Gagern wrote: ... >> It might not be worth the effort/disruption. >> One advantage of using Makefile rules is that it's easy to override >> the defaults, as you see in the examples above. > > Not so hard with shell scripts either. Use "source cfg.sh" instead of > "-include ./cfg.mk" and

Re: maint.mk syntax check problems

Martin von Gagern writes: > Re-sending for the mailing list, forgot that a moment ago. > > On 14.09.2011 16:49, Simon Josefsson wrote: >> I'm not a fan of separate shell scripts, each new file to deal with >> seems to incur a small maintainance cost over time -- consider when they >> are renamed

Re: maint.mk syntax check problems

Re-sending for the mailing list, forgot that a moment ago. On 14.09.2011 16:49, Simon Josefsson wrote: > I'm not a fan of separate shell scripts, each new file to deal with > seems to incur a small maintainance cost over time -- consider when they > are renamed or moved. I think gnulib already in

Re: maint.mk syntax check problems

Martin von Gagern writes: > And I'm still interested in some feedback what you think about turning > those syntax checks into a shell script file instead of embedding so > much ugly backslash-continued shell code into the makefile. I'm not a fan of separate shell scripts, each new file to deal w

Re: maint.mk syntax check problems

Martin von Gagern wrote: ... 5. sc_prohibit_always-defined_macros reports missing files: The sc_prohibit_always-defined_macros check will cause error messages about missing files to be emitted if elements from the gl_other_headers_ list are not present (i.e. not imported).

Re: maint.mk syntax check problems

Thanks, Jim, for the swift reply this time! On 14.09.2011 14:49, Jim Meyering wrote: >>> 1. main.mk fails its own checks: >>> >>> The checks sc_makefile_at_at_check and sc_prohibit_undesirable_word_seq >>> both fail for me, as the maint.mk file itself violates these checks. >>> >>> I know, this wi

Re: maint.mk syntax check problems

Martin von Gagern wrote: > I recently wrote a mail with various remarks about how maint.mk syntax > checks give false positives, and some suggestions to avoid these. Bruno > Haible was kind enough to voice an opinion on items 2 and 3 of that > list, but I have seen no reply to any of the other prob

Re: maint.mk syntax check problems

Hi! I recently wrote a mail with various remarks about how maint.mk syntax checks give false positives, and some suggestions to avoid these. Bruno Haible was kind enough to voice an opinion on items 2 and 3 of that list, but I have seen no reply to any of the other problems. And I'm still interes

Re: maint.mk syntax check problems

Hi Bruno, thanks for your reply! On 05.09.2011 21:45, Bruno Haible wrote: > I don't think it makes sense to run such stylistic checks on files that > are not under your control. po/Makefile.in.in is owned by the gettext > maintainer, and the *.po files are in the hands of the translators. > In ot

Re: maint.mk syntax check problems

Hi, Martin von Gagern wrote: > 2. sc_prohibit_undesirable_word_seq and gettext: > > Makefile.in.in as generated by gettextize will contain the undesirable > phrase "can not" ... > > 3. sc_prohibit_doubled_word and non-ASCII text: > > In my po/pt_BR.po file >

maint.mk syntax check problems

Hi! I'm currently updating GNU wdiff to use latest gnulib, 2c53fc42. In the process, I've encountered a number of problems with maint.mk syntax checks. 1. main.mk fails its own checks: The checks sc_makefile_at_at_check and sc_prohibit_undesirable_word_seq both fail for me, as the maint.mk file

Re: maint.mk syntax-check buglet

Jim Meyering writes: > Simon Josefsson wrote: >> I noticed this: >> >> m4/gnulib-comp.m4:62:m4_defn([m4_PACKAGE_VERSION])), [1], [], >> m4/gnulib-comp.m4:64:[GNUmakefile=$GNUmakefile])]) >> maint.mk: found SPACE-TAB sequence; remove the SPACE >> make: *** [sc_space_tab] Error 1 >>

Re: maint.mk syntax-check buglet

Simon Josefsson wrote: > I noticed this: > > m4/gnulib-comp.m4:62: m4_defn([m4_PACKAGE_VERSION])), [1], [], > m4/gnulib-comp.m4:64: [GNUmakefile=$GNUmakefile])]) > maint.mk: found SPACE-TAB sequence; remove the SPACE > make: *** [sc_space_tab] Error 1 > > How about the patch below?

maint.mk syntax-check buglet

I noticed this: m4/gnulib-comp.m4:62: m4_defn([m4_PACKAGE_VERSION])), [1], [], m4/gnulib-comp.m4:64: [GNUmakefile=$GNUmakefile])]) maint.mk: found SPACE-TAB sequence; remove the SPACE make: *** [sc_space_tab] Error 1 How about the patch below? /Simon 2011-04-25 Simon Josefsson *

Re: [PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

/ChangeLog @@ -1,5 +1,10 @@ 2010-04-27 Jim Meyering + maint.mk: avoid side-effect in latest syntax-check + * top/maint.mk (sc_prohibit_always_true_header_tests): Rework not + to run commands via $(shell...), and hence to incur cost only when + the new rule is actually run.

Re: [PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

On 27/04/10 13:15, Jim Meyering wrote: > I've just pushed the patch below. > It exposed a few unnecessary #if tests in coreutils: Very nice check. > Hence the compromise of searching for all of them at once, > with the downside that occasionally you'll be warned about > a line like this one (from

[PATCH] maint.mk: syntax-check: prohibit HAVE__H that are always true

--color option, if a test determines it's available. Alternatively, write some perl to do something similar. I haven't been motivated to do that yet. Patches welcome. >From e98ea566d814c4e7df9f8988a01e4f970a427745 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 9 Apr 2010

Re: maint.mk syntax-check

Jim Meyering writes: > Simon Josefsson wrote: >> It would be useful to have 'syntax-check' never check certain >> files/directories. This patch makes it possible to set VC_LIST_NEVER in >> cfg.mk. Objections to pushing? >> >> /Simon >> >> 2010-01-12 Simon Josefsson >> >> * top/maint.mk

Re: maint.mk syntax-check

Simon Josefsson wrote: > It would be useful to have 'syntax-check' never check certain > files/directories. This patch makes it possible to set VC_LIST_NEVER in > cfg.mk. Objections to pushing? > > /Simon > > 2010-01-12 Simon Josefsson > > * top/maint.mk (VC_LIST_EXCEPT): Filter list thr

maint.mk syntax-check

It would be useful to have 'syntax-check' never check certain files/directories. This patch makes it possible to set VC_LIST_NEVER in cfg.mk. Objections to pushing? /Simon 2010-01-12 Simon Josefsson * top/maint.mk (VC_LIST_EXCEPT): Filter list through VC_LIST_NEVER regexp to