Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-19 Thread Bruno Haible
Hi Paul, > Anyway, I've verified that the following patch fixes the bug on > Solaris 8, so I've pushed it into gnulib. Thanks for this fix, and the preceding one regarding fdopendir(). I could reproduce the problem with a testdir for module 'getcwd', and I've verified that with these two fixes,

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-19 Thread Kai Habel
Am 19.11.2011 03:07, schrieb Paul Eggert: Thanks for the further details about the problem. On 11/18/11 14:54, Mats Erik Andersson wrote: # if ! HAVE_WORKING_FSTATAT_ZERO_FLAG # define AT_FUNC_NAME rpl_fstatat # else # define AT_FUNC_NAME fstatat # endif ... This is probably broken. Right y

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-19 Thread Mats Erik Andersson
fredag den 18 november 2011 klockan 18:07 skrev Paul Eggert detta: > Thanks for the further details about the problem. > > [...] > > Anyway, I've verified that the following patch fixes the bug on > Solaris 8, so I've pushed it into gnulib. > > Can you please try it for OpenBSD 4? Thanks. I'll

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Paul Eggert
Thanks for the further details about the problem. On 11/18/11 14:54, Mats Erik Andersson wrote: > # if ! HAVE_WORKING_FSTATAT_ZERO_FLAG > # define AT_FUNC_NAME rpl_fstatat > # else > # define AT_FUNC_NAME fstatat > # endif > > ... This is probably broken. Right you are. The macro should depen

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Mats Erik Andersson
Dear Paul, fredag den 18 november 2011 klockan 12:52 skrev Paul Eggert detta: > On 11/18/11 12:07, Mats Erik Andersson wrote: > > > The [fstatat] module is built, but not automatically included in "libgnu.a". > > OK, thanks. Now we need to find out why that problem is happening. Recently Bruno

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Paul Eggert
On 11/18/11 12:07, Mats Erik Andersson wrote: > The [fstatat] module is built, but not automatically included in "libgnu.a". OK, thanks. Now we need to find out why that problem is happening. The fstatat module lists this in its configure.ac section: gl_FUNC_FSTATAT if test $HAVE_FSTATAT = 0 ||

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Mats Erik Andersson
Dear Paul, fredag den 18 november 2011 klockan 10:23 skrev Paul Eggert detta: > On 11/18/11 02:25, Mats Erik Andersson wrote: > > I will back track the failure more > > Thanks. > > A similar problem was recently reported for octave on mingw; see >

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Paul Eggert
On 11/18/11 02:25, Mats Erik Andersson wrote: > I will back track the failure more Thanks. A similar problem was recently reported for octave on mingw; see . That bug report had a bit more information, enough so that I committe

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Jim Meyering
Mats Erik Andersson wrote: > torsdag den 17 november 2011 klockan 22:02 skrev Paul Eggert detta: >> On 11/17/11 13:51, Mats Erik Andersson wrote: >> > Why is your code not falling back to the native getcwd()? >> >> Presumably the OpenBSD getcwd has some sort of >> incompatibility or bug, and gnulib

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-18 Thread Mats Erik Andersson
torsdag den 17 november 2011 klockan 22:02 skrev Paul Eggert detta: > On 11/17/11 13:51, Mats Erik Andersson wrote: > > Why is your code not falling back to the native getcwd()? > > Presumably the OpenBSD getcwd has some sort of > incompatibility or bug, and gnulib's trying to work around it. > Wi

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-17 Thread Paul Eggert
On 11/17/11 13:51, Mats Erik Andersson wrote: > Why is your code not falling back to the native getcwd()? Presumably the OpenBSD getcwd has some sort of incompatibility or bug, and gnulib's trying to work around it. Without more information, it's hard to say for sure.. Is the complete source code

libgnu: rpl_getcwd broken on OpenBSD 4.6

2011-11-17 Thread Mats Erik Andersson
(CC to bug-inetutils) Today the compilation of libgnu for GNU Inetutils is broken in rpl_getcwd on OpenBSD 4.6. The code is correct for GNU/Linux, GNU/kFreeBSD, and GNU/OpenSolaris, but not OpenBSD. The linker is not able to detect lib/getcwd.c: 246: undefined reference to 'fdopendir' lib/g