Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-30 Thread Paul Eggert
Thanks. I also noticed a tiny performance glitch in my recent intprops.h changes, which I fixed with the attached. >From ea38053c25508e8cae0c077984caf2bbe3f1b4dd Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 30 Aug 2016 12:29:21 -0700 Subject: [PATCH] intprops: tune INT_NEGATE_OVERFLOW fo

Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Jim Meyering
On Mon, Aug 29, 2016 at 3:58 PM, Jim Meyering wrote: > On Mon, Aug 29, 2016 at 12:05 PM, Paul Eggert wrote: >> Jim Meyering wrote: >> >>> Good catch. >>> Thanks. >> >> >> In trying it out on GNU Emacs with GCC 6.2 I ran into another problem: it >> complains at compile-time if __builtin_add_overfl

Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Jim Meyering
On Mon, Aug 29, 2016 at 12:05 PM, Paul Eggert wrote: > Jim Meyering wrote: > >> Good catch. >> Thanks. > > > In trying it out on GNU Emacs with GCC 6.2 I ran into another problem: it > complains at compile-time if __builtin_add_overflow's 3rd arg is null. In > some GCC versions this is supposed to

Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Paul Eggert
Jim Meyering wrote: Good catch. Thanks. In trying it out on GNU Emacs with GCC 6.2 I ran into another problem: it complains at compile-time if __builtin_add_overflow's 3rd arg is null. In some GCC versions this is supposed to discard the value, but I guess that capability is superseded by _

Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Jim Meyering
On Mon, Aug 29, 2016 at 10:17 AM, Paul Eggert wrote: > Thanks for those fixes from the bleeding edge! One minor point: a strict > reading of the GCC 7 manual would say that calls to __builtin_add_overflow_p > etc. should use __typeof__ to avoid overflow in the very expression one is > trying to ch

Re: intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Paul Eggert
Thanks for those fixes from the bleeding edge! One minor point: a strict reading of the GCC 7 manual would say that calls to __builtin_add_overflow_p etc. should use __typeof__ to avoid overflow in the very expression one is trying to check for overflow, so I installed the attached followup. Fro

intprops.h xalloc-oversized.h: fix typos and port to gcc-7

2016-08-29 Thread Jim Meyering
From b9c364f02cb7a7485cd063fa2cbcbf82042fa8cc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 29 Aug 2016 09:27:50 -0700 Subject: [PATCH 1/2] intprops.h: fix missing-backslash problems * lib/intprops.h (_GL_ADD_OVERFLOW): Add backslash. (_GL_SUBTRACT_OVERFLOW,_GL_MULTIPLY_OVERFLOW): Likew