Re: iconv.m4: avoid warning

Hi Eric, Eric Blake wrote in : > > I don't see how to test for a new vs. an old definition of AC_DEFUN_ONCE. > > You can use the existence of gnulib's witness macro (in 00gnulib.m4) as > the proof of a working AC_DEFUN_ONCE prio

Re: iconv.m4: avoid warning

On 05/18/2010 03:06 AM, Bruno Haible wrote: > Hi Eric, > >> Typo in the ChangeLog; s/AM_DEFUN_ONCE/AC_DEFUN_ONCE/ > > Oops. Fixed now. Thanks. > >>> +m4_version_prereq([2.64],[AC_DEFUN_ONCE],[AC_DEFUN])([AM_ICONV], >> >> ... rather than have a version check, I'd rather see: >> >> m4_ifdef([AC_D

Re: iconv.m4: avoid warning

Hi Eric, > Typo in the ChangeLog; s/AM_DEFUN_ONCE/AC_DEFUN_ONCE/ Oops. Fixed now. Thanks. > > +m4_version_prereq([2.64],[AC_DEFUN_ONCE],[AC_DEFUN])([AM_ICONV], > > ... rather than have a version check, I'd rather see: > > m4_ifdef([AC_DEFUN_ONCE],[AC_DEFUN_ONCE],[AC_DEFUN])([AM_ICONV], Remem

Re: iconv.m4: avoid warning

On 05/16/2010 03:51 PM, Bruno Haible wrote: > Somehow I got this autoconf warning: > > configure.ac:127: warning: AC_REQUIRE: `AM_ICONV' was expanded before it > was required > > AM_ICONV is AC_REQUIREd in many places, but documented as an invokable macro > in > the gettext documentation. The

iconv.m4: avoid warning

Somehow I got this autoconf warning: configure.ac:127: warning: AC_REQUIRE: `AM_ICONV' was expanded before it was required AM_ICONV is AC_REQUIREd in many places, but documented as an invokable macro in the gettext documentation. Therefore it makes sense to use AC_DEFUN_ONCE. I'm applying this