Re: gnulib-tool.py: Stop using codecs.open

2024-04-14 Thread Collin Funk
Hi Bruno, On 4/14/24 3:16 PM, Bruno Haible wrote: > I verified that on Cygwin, the test suite passes; this is because > - Cygwin programs produce LF as line terminator, > - Python's platform.system() returns "CYGWIN_NT-10.0". > > Regarding native Windows, I don't think there's a realistic use

Re: gnulib-tool.py: Stop using codecs.open

2024-04-14 Thread Bruno Haible
Hi Collin, > You mentioned removing the constants.nlconvert() stuff in > an earlier email [1]. How about these two patches? I verified that on Cygwin, the test suite passes; this is because - Cygwin programs produce LF as line terminator, - Python's platform.system() returns "CYGWIN_NT-10.0".

Re: gnulib-tool.py: Stop using codecs.open

2024-04-14 Thread Collin Funk
Hi Bruno, On 4/13/24 4:08 AM, Bruno Haible wrote: > It seems that codecs.open is frowned upon, nowadays [1], > and that the Python 3 way of opening a file is a built-in function 'open' [2]. Thanks for this patch. When I started working on gnulib-tool.py I didn't even know the codecs module existe

gnulib-tool.py: Stop using codecs.open

2024-04-13 Thread Bruno Haible
-in-python [2] https://docs.python.org/3/library/functions.html#open 2024-04-13 Bruno Haible gnulib-tool.py: Stop using codecs.open. * pygnulib/*.py: To open a file, consistently use open(..., mode='[rwa]', newline='\n', encoding='utf-8'). d