Re: gnulib-tool.py: Don't discard the 'dummy' module.

2024-03-31 Thread Bruno Haible
Collin Funk wrote: > I imagine many of those times the only purpose of 'sort' was to make > sure that 'join' worked since it requires the field being joined on to > be sorted right? Correct, that was one motivation to use 'sort'. The other one was to remove duplicates, because I did not know of an

Re: gnulib-tool.py: Don't discard the 'dummy' module.

2024-03-30 Thread Collin Funk
On 3/30/24 4:29 PM, Bruno Haible wrote: > I see. This is similar to the initial code for the GLMakefileTable, which > cloned the table row in the getter. Here it sorted the lists in the setter. > Feels like a "safety first" attitude that was slightly exaggerated. Maybe. I also added 'sorted(set(mo

Re: gnulib-tool.py: Don't discard the 'dummy' module.

2024-03-30 Thread Bruno Haible
Collin Funk wrote: > In a few of the import tests gnulib-tool.py doesn't add the 'dummy' > module even though gnulib-tool.sh does. > > This is because the 'dummy' module was added after GLImport saved the > modules in the GLModuleTable: > > # Transmit base_modules, final_modules, main_mod

gnulib-tool.py: Don't discard the 'dummy' module.

2024-03-30 Thread Collin Funk
s changed, 20 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6d31a954c7..0c5695231f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2024-03-30 Collin Funk + + gnulib-tool.py: Don't discard the 'dummy' module. + * pygnulib/GLImport.py (GLImport.pr