Re: gnulib/lib/lstat.c on DJGPP v2.04

2011-02-25 Thread Eli Zaretskii
> Date: Fri, 25 Feb 2011 15:12:18 -0800 > From: Paul Eggert > CC: bug-gnulib@gnu.org > > On 02/25/2011 02:33 PM, Eli Zaretskii wrote: > > > My suggestion is simply to use ISSLASH everywhere. > > This would make the code everywhere harder to read. Since ISSLASH is already used elsewhere, I can

Re: gnulib/lib/lstat.c on DJGPP v2.04

2011-02-25 Thread Eric Blake
On 02/25/2011 04:12 PM, Paul Eggert wrote: >> That might be so now, but a month or a year from now, someone will >> decide that gnulib's `lstat' needs to fix some other anomaly, which >> will cause DJGPP builds of some package out there to use this code. > > Anyone who decides that should of cours

Re: gnulib/lib/lstat.c on DJGPP v2.04

2011-02-25 Thread Paul Eggert
On 02/25/2011 02:33 PM, Eli Zaretskii wrote: My suggestion is simply to use ISSLASH everywhere. This would make the code everywhere harder to read. As a general rule, Gnulib code uses ISSLASH only when needed. Not only does this make the typical case simpler, it makes it clearer to the reader

Re: gnulib/lib/lstat.c on DJGPP v2.04

2011-02-25 Thread Eli Zaretskii
> Date: Fri, 25 Feb 2011 13:41:41 -0800 > From: Paul Eggert > CC: Bug-gnulib > > On 02/23/2011 01:47 AM, Eli Zaretskii wrote in > : > > > An example of what could go wrong with these replacements can be seen > > in this excer

gnulib/lib/lstat.c on DJGPP v2.04

2011-02-25 Thread Paul Eggert
On 02/23/2011 01:47 AM, Eli Zaretskii wrote in : An example of what could go wrong with these replacements can be seen in this excerpt from rpl_lstat: + /* This replacement file can blindly check against '/' rather than