That change is fine.
On 09/08/2013 11:18 PM, Tom G. Christensen wrote:
> [resend with Cc to bug-gnulib]
>
> On 09/07/2013 03:04 PM, Eric Blake wrote:
>> Ah, we need _both_ spellings, as we do have other uses of __THROW. I'll
>> check in the obvious fix shortly.
>>
> The obvious fix you checked in is missing an #endif
[resend with Cc to bug-gnulib]
On 09/07/2013 03:04 PM, Eric Blake wrote:
Ah, we need _both_ spellings, as we do have other uses of __THROW. I'll
check in the obvious fix shortly.
The obvious fix you checked in is missing an #endif.
From build on CentOS 5:
In file included from glob.c:24:
./g
On 09/07/2013 05:32 AM, Tom G. Christensen wrote:
>>
>> * posix/glob.c (next_brace_sub, prefix_array, collated_compare):
>> Use __THROWNL rather than __THROW on static functions.
>>
>
> This broke the build for atleast Solaris and FreeBSD.
>
> Here's an excerpt from a test build on FreeBSD 9.1:
On 09/05/2013 01:05 AM, Eric Blake wrote:
From c84321367fb6d1dc35c8d04e075f1315eddcc720 Mon Sep 17 00:00:00 2001
From: Eric Blake
Date: Wed, 4 Sep 2013 17:02:47 -0600
Subject: [PATCH] glob: silence -Wattribute warnings
Colin Watson reported that some versions of gcc warn about
attribute leaf us
On 09/04/2013 06:31 AM, Eric Blake wrote:
> [just now noticing an old thread]
>
> On 06/03/2013 05:05 AM, Colin Watson wrote:
>> I get these warnings from a project using Gnulib 20130529:
>>
>> glob.c:165:1: warning: '__leaf__' attribute has no effect on unit local
>> functions [-Wattributes]
>
[just now noticing an old thread]
On 06/03/2013 05:05 AM, Colin Watson wrote:
> I get these warnings from a project using Gnulib 20130529:
>
> glob.c:165:1: warning: '__leaf__' attribute has no effect on unit local
> functions [-Wattributes]
> glob.c:213:1: warning: '__leaf__' attribute has
I get these warnings from a project using Gnulib 20130529:
glob.c:165:1: warning: '__leaf__' attribute has no effect on unit local
functions [-Wattributes]
glob.c:213:1: warning: '__leaf__' attribute has no effect on unit local
functions [-Wattributes]
glob.c:214:1: warning: '__leaf__' att
