Re: [PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted

On 01/11/2012 01:49 PM, Dmitry V. Levin wrote: > Ping? > > - Forwarded message from "Dmitry V. Levin" - > > Date: Sun, 24 Apr 2011 13:44:38 +0400 > From: "Dmitry V. Levin" > To: bug-gnulib@gnu.org > Subject: [PATCH] getloadavg test: skip th

Re: [PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted

Ping? - Forwarded message from "Dmitry V. Levin" - Date: Sun, 24 Apr 2011 13:44:38 +0400 From: "Dmitry V. Levin" To: bug-gnulib@gnu.org Subject: [PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted GNU libc implements getloadavg(3) on Li

[PATCH] getloadavg test: skip the test on GNU/Linux without /proc mounted

/test-getloadavg.c |2 +- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 82c8468..0569fe0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2011-04-24 Dmitry V. Levin + + getloadavg test: skip the test on GNU/Linux without /proc mounted

Re: getloadavg test

Hi Paul, > Sure, something like that sounds fine. Though I'd > make the upper bound higher than 100. Maybe a million? > ... high load factors are not that uncommon on real-world > multiple-CPU machines. Thanks for the advice. I pushed it with 100 as plausibility limit. Bruno -- In memoria

Re: getloadavg test

On 02/16/2011 03:28 AM, Bruno Haible wrote: How about this? It's basically what a human would do when executing the manual test. Sure, something like that sounds fine. Though I'd make the upper bound higher than 100. Maybe a million? Sun bug 4756989 was a user complaining that SunOS getloada

Re: getloadavg test

aible getloadavg test: Add some plausibility checks. * tests/test-getloadavg.c (check_avg): Print a warning when the value is improbable. --- tests/test-getloadavg.c.origWed Feb 16 12:24:44 2011 +++ tests/test-getloadavg.c Wed Feb 16 12:24:21 2011 @@ -30,6 +

Re: getloadavg test

Thanks for that review, Bruno. I'll add the following before pushing: From c46ceeaabfab5055455daf282e64bc37d3a98ea9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 15 Feb 2011 13:09:20 -0800 Subject: [PATCH] test-getloadavg: make it act like other tests Suggested by Bruno Haible in

Re: getloadavg test

Hi Paul, > Move test code to ... > * tests/test-getloadavg.c: New file, containing previous > contents of test from lib/getloadavg.c. > * modules/getloadavg-tests: New file. This test can be run in two modes: - simple test: call getloadavg once, and print one line. - repeated test: call getlo