Re: filemode: Add tests.

2024-06-19 Thread Bruno Haible
Hi Collin, > > Since the test includes , it should depend on the 'unistd' > > module. Just to make sure we don't encounter a compilation error on > > native Windows. > > Ah, okay. I thought that would only be necessary if using a function > from or macros like SEEK_*, *_FILENO, etc. You can look

Re: filemode: Add tests.

2024-06-19 Thread Collin Funk
Hi Bruno, Bruno Haible wrote: >> NetBSD fixed that declaration in 1997 [1], FreeBSD did in version >> 14.0 [2]. OpenBSD still has it declared with an int argument even >> though mode_t is a __uint32_t there [3] [4] [5]. > > Also, macOS is in the same camp as OpenBSD here. I reported it with a pr

Re: filemode: Add tests.

2024-06-19 Thread Bruno Haible
Hi Collin, > I ran into a compilation error a long time ago (not Gnulib related) > because I declared strmode using the mode_t argument unconditionally. > This is an issue because FreeBSD uses int as the first argument and > not mode_t, which is typedef'd to __uint16_t. This test is mostly to > ma

filemode: Add tests.

2024-06-18 Thread Collin Funk
penbsd/src/blob/1245b84dd8b155eea7f3aeffc9acb78e7116673b/sys/sys/_types.h#L54 [5] https://man.openbsd.org/strmode.3From d8e12a7f5082deaa2e26ca2d908915f3197ba6b1 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Tue, 18 Jun 2024 21:21:47 -0700 Subject: [PATCH] filemode: Add tests. * modules/filemode-tests: New fil