access, euidaccess tests: Avoid test failure in Cygwin 3.5.5

2024-12-24 Thread Bruno Haible via Gnulib discussion list
The GitHub CI reports these test failures: FAIL: test-access = ../../gltests/test-access.h:101: assertion 'func (BASE "f2", X_OK) == -1' failed ../../gltests/test-access.h:102: assertion 'errno == EACCES' failed FAIL test-access.exe (exit sta

euidaccess: Fix test failure on mingw

2024-05-25 Thread Bruno Haible
On mingw, I'm seeing test-euidaccess failures: ../../gltests/test-access.h:54: assertion 'errno == ENOTDIR' failed Stack trace: 0xcd2ea6c5 test_access ../../gltests/test-access.h:54 0xcd2ea6c5 main ../../gltests/test-euidaccess.c:37 ../../gltests/test-access.

access, euidaccess tests: Avoid test failures on Cygwin

2024-05-23 Thread Bruno Haible
On the Cygwin 3.3.6 and 3.5.3 machines at GitHub I see these test failures: FAIL: test-access = ../../gltests/test-access.h:83: assertion 'func (BASE "f2", W_OK) == -1' failed FAIL: test-euidaccess = ../../gltests/test-access.h:83: asser

Re: access, euidaccess tests: Avoid test failure for root user on Solaris

2024-05-21 Thread Bruno Haible
Collin Funk wrote: > I didn't know they were run as root (CI is new to me). That's why I start all CI runs with these commands: uname -a id env | LC_ALL=C sort pwd It helps understanding the environment :) Sometimes I need to add echo $PA

Re: access, euidaccess tests: Avoid test failure for root user on Solaris

2024-05-21 Thread Collin Funk
On 5/21/24 6:45 AM, Bruno Haible wrote: > The CI runs the Solaris 11 and Solaris 11 OmniOS tests as root, and shows > these two test failures: > > FAIL: test-access > FAIL: test-euidaccess > > This occurs because although the file does not have the 'x' bit set, &

access, euidaccess tests: Avoid test failure for root user on Solaris

2024-05-21 Thread Bruno Haible
The CI runs the Solaris 11 and Solaris 11 OmniOS tests as root, and shows these two test failures: FAIL: test-access FAIL: test-euidaccess This occurs because although the file does not have the 'x' bit set, for root faccessat() returns 0. POSIX <https://pubs.opengroup.org/onlinepu

euidaccess: Reject trailing slashes on symlinks to non-directories

2023-10-03 Thread Bruno Haible
I wrote: > On this platform, faccessat is emulated through access() and euidaccess(): > > $ nm gllib/faccessat.o > U ___error > U _access > U _euidaccess > T _faccessat > U _fchdir > U _free_cwd > U

euidaccess: port to native Windows

2018-03-20 Thread Bruno Haible
`euidaccess': /home/bruno/recutils-1.7.90/build-mingw32/lib/../../lib/euidaccess.c:89: undefined reference to `getuid' /home/bruno/recutils-1.7.90/build-mingw32/lib/../../lib/euidaccess.c:90: undefined reference to `getgid' /home/bruno/recutils-1.7.90/build-mingw32/lib/../../lib/euidaccess.c

[PATCH 06/11] euidaccess: Fix Android build

2015-02-11 Thread Kevin Cernekee
* modules/euidaccess (Depends-on): Add fcntl-h to ensure that AT_EACCESS gets declared. --- ChangeLog | 4 modules/euidaccess | 1 + 2 files changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index bbcc513261eb..7e1fb9191b6d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,6

[PATCH] euidaccess: speed up 'configure' on GNU hosts

2012-10-16 Thread Paul Eggert
--- ChangeLog| 8 m4/euidaccess.m4 | 8 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 62b0cf6..32c4c3e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,13 @@ 2012-10-16 Paul Eggert + euidaccess: speed up

euidaccess: comment

2011-11-19 Thread Bruno Haible
The list of platforms that have faccessat() has increased since this code was written. 2011-11-19 Bruno Haible euidaccess: Update a comment. * lib/euidaccess.c: Update comment about platforms with faccessat. --- lib/euidaccess.c.orig Sat Nov 19 20:53:43 2011 +++ lib

Re: euidaccess

2010-03-07 Thread Paolo Bonzini
On 03/06/2010 04:09 PM, Bruno Haible wrote: +#if defined GNULIB_POSIXCHECK +/* The access() function is a security risk. */ +_GL_WARN_ON_USE (access, "the access function is a security risk - " + "use the gnulib module faccessat instead"); +#endif How is faccessat less subject

Re: euidaccess

2010-03-06 Thread Simon Josefsson
Jim Meyering writes: > Bruno Haible wrote: >>> > Thanks -- I've pushed the modified patch. Now the only license issue >>> > within gnulib is 'euidaccess'... >> >>> + euidaccess: relax license to LGPLv2+ > > Hi Bruno, > >

Re: euidaccess

2010-03-06 Thread Jim Meyering
Bruno Haible wrote: > Jim Meyering wrote: >> For some of the same reasons, the euidaccess function/module should be >> avoided, simply because it cannot be used robustly -- by its very nature. >> Use faccessat instead. > > Here's a proposed doc update and ad

Re: euidaccess

2010-03-06 Thread Bruno Haible
Jim Meyering wrote: > For some of the same reasons, the euidaccess function/module should be > avoided, simply because it cannot be used robustly -- by its very nature. > Use faccessat instead. Here's a proposed doc update and additional warnings for the use of 'access' a

Re: euidaccess

2010-03-06 Thread Jim Meyering
Bruno Haible wrote: >> > Thanks -- I've pushed the modified patch. Now the only license issue >> > within gnulib is 'euidaccess'... > >> +euidaccess: relax license to LGPLv2+ Hi Bruno, > This won't help much, because 'euidaccess' d

Re: euidaccess

2010-03-06 Thread Bruno Haible
Hi Jim, > > Thanks -- I've pushed the modified patch. Now the only license issue > > within gnulib is 'euidaccess'... > + euidaccess: relax license to LGPLv2+ This won't help much, because 'euidaccess' depends on 'group-member', which

Re: declare euidaccess in unistd.h

2008-10-19 Thread Bruno Haible
> 2008-10-18 Bruno Haible <[EMAIL PROTECTED]> > > * lib/euidaccess.h: Remove file. > * lib/unistd.in.h (euidaccess): New declaration. > * lib/euidaccess.c: Don't include euidaccess.h. > * m4/euidaccess.m4 (gl_FUNC_EUIDACCESS): Require gl_UNI

declare euidaccess in unistd.h

2008-10-18 Thread Bruno Haible
The header file in which glibc declares euidaccess() is . Here's a proposed patch for gnulib to do the same. The patch also contains a simplification: No need to check whether euidaccess is declared. According to doc/glibc-functions/euidaccess.texi, glibc is the only platform so far that has