Eric Blake writes:
> That said, here's a review of your proposed patch:
Thanks! Here is an updated patch that I will use in my projects.
/Simon
diff --git a/gltests/dup2.c b/gltests/dup2.c
index a4422bf..b9b329c 100644
--- a/gltests/dup2.c
+++ b/gltests/dup2.c
@@ -40,6 +40,7 @@ rpl_dup2 (int
Eric Blake writes:
> According to Simon Josefsson on 1/9/2010 4:06 AM:
>> There is another dup2 failure due to Wine, see:
>>
>> http://bugs.winehq.org/show_bug.cgi?id=21291
>>
>> The patch below works around it. Thoughts?
>
> Hmm. Repeatedly adding workarounds for wine bugs seems awkward. If
According to Simon Josefsson on 1/9/2010 4:06 AM:
> There is another dup2 failure due to Wine, see:
>
> http://bugs.winehq.org/show_bug.cgi?id=21291
>
> The patch below works around it. Thoughts?
Hmm. Repeatedly adding workarounds for wine bugs seems awkward. If the
goal is making wine a wind
There is another dup2 failure due to Wine, see:
http://bugs.winehq.org/show_bug.cgi?id=21291
The patch below works around it. Thoughts?
/Simon
2010-01-09 Simon Josefsson
* lib/dup2.c (rpl_dup2): Restore text mode when needed, to work
around Wine bug #21291.
diff --git a/li
Eric Blake writes:
> According to Simon Josefsson on 1/8/2010 2:36 AM:
>> I got this on MinGW:
>>
>> test-dup2.c:140: assertion failed
>> FAIL: test-dup2.exe
>
> I wish mingw had a better version number reporting scheme. I can't
> reproduce the failure when I cross-compile from cygwin to mingw,
According to Simon Josefsson on 1/8/2010 2:36 AM:
> I got this on MinGW:
>
> test-dup2.c:140: assertion failed
> FAIL: test-dup2.exe
I wish mingw had a better version number reporting scheme. I can't
reproduce the failure when I cross-compile from cygwin to mingw, then run
the program natively o
I got this on MinGW:
test-dup2.c:140: assertion failed
FAIL: test-dup2.exe
The relevant code is:
/* The destination must be valid. */
errno = 0;
ASSERT (dup2 (fd, -2) == -1);
Debugging this, it seems MinGW dup2 returns -2 in this situation. Any
ideas? Is -2 a valid file descriptor on M
