Bruno Haible <[EMAIL PROTECTED]> writes:
> Simon Josefsson wrote:
>> I changed the namespace to gl_des as below.
>
> After the complaints "gnulib is changing too fast" a few weeks ago, I think
> it may help the gnulib users if we keep track of the incompatible changes
> (removed modules, renamed f
hanges
> (removed modules, renamed functions etc.). I'm making a start by adding this
> NEWS file.
Makes sense, thanks!
Although I believe the impact of this should be small, if people use
the gc-des module as the high-level interface to DES functions. Doing
that is better. I added a note about this.
/Simon
Simon Josefsson wrote:
> I changed the namespace to gl_des as below.
After the complaints "gnulib is changing too fast" a few weeks ago, I think
it may help the gnulib users if we keep track of the incompatible changes
(removed modules, renamed functions etc.). I'm making a start by adding this
NE
Bruno Haible <[EMAIL PROTECTED]> writes:
> Hi Simon,
>
> On MacOS X 10.3.9 the 'gc-gnulib' (or 'gc-des') module fails to build:
>
> depbase=`echo gc-gnulib.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -DEXEE
Bruno Haible <[EMAIL PROTECTED]> writes:
> Hi Simon,
>
> The gc-des module contains the lib/des.h header, which include .
> So it should depend on 'stdbool'. Currently, it doesn't, and the compiler
> on Solaris 8 complains:
>
> cc -O -DHAVE_CONFIG_H -I.
Hi Simon,
On MacOS X 10.3.9 the 'gc-gnulib' (or 'gc-des') module fails to build:
depbase=`echo gc-gnulib.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -std=gnu99 -DHAVE_CONFIG_H -DEXEEXT=\"\" -DEXEEXT=\"\" -DNO_XMALLOC
-DEXEEXT=\"\&quo
Hi Simon,
The gc-des module contains the lib/des.h header, which include .
So it should depend on 'stdbool'. Currently, it doesn't, and the compiler
on Solaris 8 complains:
cc -O -DHAVE_CONFIG_H -I. -I.. -g -c des.c
"./des.h", line 28: cannot find include
char "=" pointer to const char
> "des.c", line 636: warning: assignment type mismatch:
> pointer to unsigned char "=" pointer to char
>
> Here is a fix: Add casts.
Applied, thanks!
> Bruno
>
>
> *** lib/des.c.bak 2005-10-21 14:2
ointer to unsigned char "=" pointer to char
Here is a fix: Add casts.
Bruno
*** lib/des.c.bak 2005-10-21 14:28:18.0 +0200
--- lib/des.c 2006-05-07 16:50:07.0 +0200
***
*** 1,5
/* des.c --- DES and Triple-DES encryption/decryption Algorithm
! * Copyr
The des_setkey function still collides with the one on MacOS X:
gcc -DHAVE_CONFIG_H -I. -I../../../megatestdir/gc-des/lib -I.. -g -O2 -c
../../../megatestdir/gc-des/lib/gc-gnulib.c
In file included from ../../../megatestdir/gc-des/lib/gc-gnulib.c:65:
../../../megatestdir/gc-des/lib/des.h:62
crosystems, Inc. and is provided for
> * unrestricted use provided that
I think that license is OK; it's compatible with the LGPL.
> Unless someone feel strongly (and, preferably, even want to do the leg
> work...) I'll simply fix the
API uses as input 64 byte long strings,
where each char is either "0" or "1". I.e., it uses an ASCII-encoding
of each block. That is definitely not something we should promote.
However, I discovered that glibc has another DES implementation:
ecb_crypt and cbc_crypt in rpc/des
; on that system, I get a man page
for libcrypt. 'des_setkey' isn't mention on the page. However,
considering the prototype in unistd.h:
int des_setkey __P((const char *key));
I would suspect the function somehow sets a global DES key schedule
struct somewhere.
Oh. There is a POSIX
Hello,
On Sun, Oct 23, 2005 at 10:25:48PM -0700, Paul Eggert wrote:
> Simon Josefsson <[EMAIL PROTECTED]> writes:
> > In file included from smbutil.c:34:
> > lib/des.h:62: conflicting types for `des_setkey'
...
> If they are supposed to have the same semantics but the FreeBSD
> versions are buggy,
Simon Josefsson <[EMAIL PROTECTED]> writes:
> I get this on freebsd 4.11:
>
> In file included from smbutil.c:34:
> lib/des.h:62: conflicting types for `des_setkey'
> /usr/include/unistd.h:128: previous declaration of `des_setkey'
> *** Error code 1
>
> Should I rename the des_* functions to gl_de
I get this on freebsd 4.11:
In file included from smbutil.c:34:
lib/des.h:62: conflicting types for `des_setkey'
/usr/include/unistd.h:128: previous declaration of `des_setkey'
*** Error code 1
Should I rename the des_* functions to gl_des_* or is there some
cleaner approach?
__
:10 -
@@ -1,5 +1,13 @@
2005-10-21 Simon Josefsson <[EMAIL PROTECTED]>
+ * modules/des, modules/des-tests: New files.
+
+ * modules/gc-des, modules/gc-des-tests: New files.
+
+ * tests/test-des.c, tests/test-gc-des.c: New file.
+
+2005-10-21 Simon Josefsson &
Has anyone else reviewed this module? Ok to install?
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
\. S/, s/
>
>> + * is no need for a decryption rotate tab.
>> + */
>> +static const unsigned char encrypt_rotate_tab[16] = {
>> + 1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1
>> +};
>> +
>> +/*
>> + * Table with weak DES keys sorted in ascending order.
* Ralf Wildenhues wrote on Fri, Oct 14, 2005 at 01:55:32PM CEST:
> * Simon Josefsson wrote on Fri, Oct 14, 2005 at 01:23:25PM CEST:
> > +/*
> > + * Table with weak DES keys sorted in ascending order.
> > + * In DES their are 64 known keys wich are weak. They are weak
>
eir
s/their/there/; I'd also do s/\. S/, s/
> + * is no need for a decryption rotate tab.
> + */
> +static const unsigned char encrypt_rotate_tab[16] = {
> + 1, 1, 2, 2, 2, 2, 2, 2, 1, 2, 2, 2, 2, 2, 2, 1
> +};
> +
> +/*
> + * Table with weak DES keys sorted in ascending
Ok to install?
Comments welcome, of course.
Index: modules/des
===
RCS file: modules/des
diff -N modules/des
--- /dev/null 1 Jan 1970 00:00:00 -
+++ modules/des 14 Oct 2005 11:23:02 -
@@ -0,0 +1,25 @@
+Description:
+DES
22 matches
Mail list logo
