Re: copy-file.c vs ignoring chown's return value

2011-03-01 Thread Bruno Haible
Hi Jim, > * lib/copy-file.c: Include "ignore-value.h". > (copy_file_preserving): Ignore chown failure. > * modules/copy-file (Depends-on): Add ignore-value. Looks all fine, no objection. Thank you. > One is to add this pragma along with a comment somewhere in copy-file.c: > > # pragma GCC d

copy-file.c vs ignoring chown's return value

2011-03-01 Thread Jim Meyering
Hi Bruno, We're about to use the copy-file module in iwhd, and I'm seeing this warning/error with our gcc options: copy-file.c: In function 'copy_file_preserving': copy-file.c:120:9: error: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result] I see