Re: c-stack.c and DEBUG: missing import

2020-05-16 Thread Marc Nieper-Wißkirchen
Thank you, both of you! Have a nice weekend, Marc Am Fr., 15. Mai 2020 um 23:04 Uhr schrieb Bruno Haible : > > Hi Paul, > > > I don't think we need to go that far, since c-stack is already using > > ignore_value. I installed the attached. > > You beat me to it by 2 minutes :) > > I verified that

Re: c-stack.c and DEBUG: missing import

2020-05-15 Thread Bruno Haible
Hi Paul, > I don't think we need to go that far, since c-stack is already using > ignore_value. I installed the attached. You beat me to it by 2 minutes :) I verified that the patch fixes the warning that occurred with ./configure CPPFLAGS="-Wall -DDEBUG" --with-libsigsegv-prefix=... Bruno

Re: c-stack.c and DEBUG: missing import

2020-05-15 Thread Paul Eggert
On 5/14/20 7:01 AM, Marc Nieper-Wißkirchen wrote: > This will be a nice use case for the newly created attribute module > and MAYBE_UNUSED. I don't think we need to go that far, since c-stack is already using ignore_value. I installed the attached. >From c8c5f321dd10b21c8ad55f5c134c93235ffc9930 M

Re: c-stack.c and DEBUG: missing import

2020-05-14 Thread Marc Nieper-Wißkirchen
Hi Bruno, there is one more issue with c-stack when all warnings are enabled (and the DEBUG flag is set): c-stack.c: In function ‘segv_handler’: c-stack.c:175:5: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] 175 | write (STDERR_FILEN

Re: c-stack.c and DEBUG: missing import

2020-05-09 Thread Bruno Haible
Hi Marc, > Please add > > #ifdef DEBUG > # include > #endif > > at the beginning of c-stack.c. > > When the DEBUG flag is enabled, c-stack.c uses sprintf and without the > suggested addition gcc complains about an implicit declaration of the > function sprintf. Yup. Thanks for the suggestion.

c-stack.c and DEBUG: missing import

2020-05-09 Thread Marc Nieper-Wißkirchen
Please add #ifdef DEBUG # include #endif at the beginning of c-stack.c. When the DEBUG flag is enabled, c-stack.c uses sprintf and without the suggested addition gcc complains about an implicit declaration of the function sprintf. Thanks, Marc