Re: bug in use of AC_HEADER_DIRENT

2006-03-20 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > By the way, my patch added an "-*- Autoconf -*-" modeline, so that it > was easier to edit in emacs (for example, AC_ macros are colorized by > font-lock, and emacs looks for [] instead of `' as quoting pairs). Is > it worth doing this to other m4 files in

Re: bug in use of AC_HEADER_DIRENT

2006-03-20 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > By the way, my patch added an "-*- Autoconf -*-" modeline, so that it > was easier to edit in emacs (for example, AC_ macros are colorized by > font-lock, and emacs looks for [] instead of `' as quoting pairs). Is > it worth doing this to other m4 files in g

Re: bug in use of AC_HEADER_DIRENT

2006-03-16 Thread Eric Blake
Paul Eggert CS.UCLA.EDU> writes: > > only the dirfd.m4 change was necessary to solve the problem at hand. > > OK, thanks, could you please apply that? Committed only the dirfd.m4 changes. By the way, my patch added an "-*- Autoconf -*-" modeline, so that it was easier to edit in emacs (for exa

Re: bug in use of AC_HEADER_DIRENT

2006-03-16 Thread Ralf Wildenhues
Hi Eric, * Eric Blake wrote on Tue, Mar 14, 2006 at 06:08:02PM CET: > CVS findutils currently tickles a bug in its use of AC_HEADER_DIRENT. > Somehow, the combination of modules pulled in by findutils led to > the following macro chain (among others): > > gl_INIT > +-gl_FUNC_DIRFD > | +-AC_HEADER

Re: bug in use of AC_HEADER_DIRENT

2006-03-15 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Huh - you're right. I reverted my getcwd.m4 changes, and everything still > worked in findutils' ./configure, so it was only the dirfd.m4 change > necessary to solve the problem at hand. So only half my patch needs to be > applied. OK, thanks, could you

Re: bug in use of AC_HEADER_DIRENT

2006-03-14 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 3/14/2006 2:36 PM: >> * dirfd.m4 (gl_FUNC_DIRFD): Use AC_REQUIRE for AC_HEADER_DIRENT. >> * getcwd.m4 (gl_FUNC_GETCWD): Require gl_PREREQ_GETCWD outside >> of shell conditionals. > > I can see the need for th

Re: bug in use of AC_HEADER_DIRENT

2006-03-14 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > 2006-03-14 Eric Blake <[EMAIL PROTECTED]> > > * dirfd.m4 (gl_FUNC_DIRFD): Use AC_REQUIRE for AC_HEADER_DIRENT. > * getcwd.m4 (gl_FUNC_GETCWD): Require gl_PREREQ_GETCWD outside > of shell conditionals. I can see the need for the dirfd pa

bug in use of AC_HEADER_DIRENT

2006-03-14 Thread Eric Blake
CVS findutils currently tickles a bug in its use of AC_HEADER_DIRENT. Somehow, the combination of modules pulled in by findutils led to the following macro chain (among others): gl_INIT +-gl_FUNC_DIRFD | +-AC_HEADER_DIRENT +-gl_FUNC_FTS | +-AC_REQUIRE([gl_FUNC_FTS_CORE]) | +-AC_REQUIRE([AC_HEADE