Re: bug#25390: Segfault with sed 4.3

2017-01-16 Thread Assaf Gordon
tag 25390 fixed close 25390 thanks Hello, Thanks again for everyone who reported, fixed and improved sed and dfa/gnulib. sed's update to latest gnulib is pushed here: http://git.savannah.gnu.org/cgit/sed.git/commit/?id=44d99bf5c98ea77de0addf55ad7fe281396de996 followed by the new test: http

Re: [Grep-devel] bug#25390: Segfault with sed 4.3

2017-01-14 Thread Jim Meyering
On Mon, Jan 9, 2017 at 9:27 PM, Assaf Gordon wrote: > Hello all, > >> On Jan 9, 2017, at 09:11, Norihiro Tanaka wrote: >> >> Sorry, I adjusted commit log, New patch does not change >> testsuite/Makefile.tests. >> <0001-tests-new-test-for-dfa-crash-bug.patch> > > > Paul, > Thank you for the quick

Re: bug#25390: Segfault with sed 4.3

2017-01-10 Thread Paul Eggert
Assaf Gordon wrote: I'm also considering duplicating the test - once with and once without valgrind. Is this warranted or an overkill ? Sounds like overkill to me. If it works with valgrind, it'll work without.

Re: bug#25390: Segfault with sed 4.3

2017-01-09 Thread Assaf Gordon
Hello all, > On Jan 9, 2017, at 09:11, Norihiro Tanaka wrote: > > Sorry, I adjusted commit log, New patch does not change > testsuite/Makefile.tests. > <0001-tests-new-test-for-dfa-crash-bug.patch> Paul, Thank you for the quick fix. Norihiro, Thank you for the dfa improvements and sed-tests.

Re: bug#25390: Segfault with sed 4.3

2017-01-09 Thread Norihiro Tanaka
On Sun, 8 Jan 2017 22:12:02 -0800 Paul Eggert wrote: > Norihiro Tanaka wrote: > > I wrote two additional patches for dfa. First, derive number of > > allocation from not argument but number of state in transition table > > allocation. Second, melt down dfastate() into build_state(). Now, I >

Re: bug#25390: Segfault with sed 4.3

2017-01-09 Thread Norihiro Tanaka
On Mon, 09 Jan 2017 23:04:05 +0900 Norihiro Tanaka wrote: > Thanks, I updated the test. The new test uses valgrind. Sorry, I adjusted commit log, New patch does not change testsuite/Makefile.tests. From 67a17d942beb942acd2b2e95eba2cc3d43a5e883 Mon Sep 17 00:00:00 2001 From: Norihiro Tanaka Da

Re: bug#25390: Segfault with sed 4.3

2017-01-08 Thread S. Gilles
On 2017-01-08T12:49:42-0800, Paul Eggert wrote: > Assaf Gordon wrote: > > The immediate cause is somewhere in gnulib's DFA module. > > The bug was introduced in Gnulib, in commit > 403adf1b40897ba108075008c10bd38d937e1539 dated 2016-11-25 and labeled "dfa: > addition of new state on demand". It's

Re: bug#25390: Segfault with sed 4.3

2017-01-08 Thread Paul Eggert
Norihiro Tanaka wrote: I wrote two additional patches for dfa. First, derive number of allocation from not argument but number of state in transition table allocation. Second, melt down dfastate() into build_state(). Now, I think that there do not have to be separated. Thanks, I installed th

Re: bug#25390: Segfault with sed 4.3

2017-01-08 Thread Norihiro Tanaka
On Sun, 8 Jan 2017 12:49:42 -0800 Paul Eggert wrote: > Assaf Gordon wrote: > > The immediate cause is somewhere in gnulib's DFA module. > > The bug was introduced in Gnulib, in commit > 403adf1b40897ba108075008c10bd38d937e1539 > dated 2016-11-25 and labeled "dfa: addition of new state on deman

Re: bug#25390: Segfault with sed 4.3

2017-01-08 Thread Paul Eggert
Assaf Gordon wrote: The immediate cause is somewhere in gnulib's DFA module. The bug was introduced in Gnulib, in commit 403adf1b40897ba108075008c10bd38d937e1539 dated 2016-11-25 and labeled "dfa: addition of new state on demand". It's not a bug that grep runs into, since grep doesn't use th

Re: bug#25390: Segfault with sed 4.3

2017-01-08 Thread Assaf Gordon
Hello, > On Jan 8, 2017, at 00:31, S. Gilles wrote: > >> I have a reliable segfault with (vanilla) sed 4.3 which does not appear >> on (vanilla) 4.2.2. Thank you for the report! I can confirm the segfault is reproducible. The immediate cause is somewhere in gnulib's DFA module. A shorter examp