Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Paul Eggert
Pádraig Brady wrote: Looks good thanks, though it would be worth mentioning in the commit why extensions is used. Thanks, I pushed the attached. From 5d34c7ba14c0b85c1e9130f5ca0514d9e4adeeb2 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 14 Jun 2014 12:33:26 -0700 Subject: [PATCH] pthre

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Pádraig Brady
On 06/14/2014 06:08 PM, Paul Eggert wrote: > I looked into this some more, and found some problems: > > * On Solaris we also need to define _POSIX_PTHREAD_SEMANTICS to prefer POSIX > to pre-POSIX semantics for a few functions; see >

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Paul Eggert
I looked into this some more, and found some problems: * On Solaris we also need to define _POSIX_PTHREAD_SEMANTICS to prefer POSIX to pre-POSIX semantics for a few functions; see . The extensions module does this, so a si

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Jim Meyering
Thanks. That looks fine, but please change "thread safe" to "thread-safe" everywhere.

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-14 Thread Pádraig Brady
On 06/13/2014 11:07 PM, Paul Eggert wrote: > Pádraig Brady wrote: > > >> + case "$host_os" in >> + aix* | freebsd*) CPPFLAGS="$CPPFLAGS -D_THREAD_SAFE" ;; >> + solaris*) CPPFLAGS="$CPPFLAGS -D_REENTRANT" ;; > > Why not use AC_DEFINE([_THREAD_SAFE], 1, ...) instead? That makes fo

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-13 Thread Paul Eggert
Pádraig Brady wrote: + case "$host_os" in + aix* | freebsd*) CPPFLAGS="$CPPFLAGS -D_THREAD_SAFE" ;; + solaris*) CPPFLAGS="$CPPFLAGS -D_REENTRANT" ;; Why not use AC_DEFINE([_THREAD_SAFE], 1, ...) instead? That makes for shorter command lines in projects like Emacs. I don't s

Re: bug#17773: AIX build errors with coreutils-8.22

2014-06-13 Thread Pádraig Brady
On 06/13/2014 06:57 PM, Paul Eggert wrote: > On 06/13/2014 10:29 AM, Pádraig Brady wrote: >> So I'd be inclined to add those definitions in the pthread module, >> but if not we could define at the top of sort.c at least? > > The latter doesn't sound safe, since it would mean the files in > libcor