Re: bootstrap symlink dependencies

2011-05-16 Thread Pádraig Brady
On 16/05/11 20:47, Ralf Wildenhues wrote: > Hi Pádraig, > > * Pádraig Brady wrote on Mon, May 16, 2011 at 04:44:42PM CEST: >> On 14/05/11 09:07, Paul Eggert wrote: If something treats symlink mtime as significant, then I suspect that it's at fault. >>> >>> Yes, there's something busted t

Re: bootstrap symlink dependencies

2011-05-16 Thread Paul Eggert
On 05/16/11 12:47, Ralf Wildenhues wrote: > GNU make, I presume. I checked GNU make 3.82's source code, and I didn't see how it could be a problem with GNU make, as it uses stat, not lstat, for target timestamps. Perhaps I misread the code, but I think it more likely the problem is elsewhere. (So

Re: bootstrap symlink dependencies

2011-05-16 Thread Ralf Wildenhues
Hi Pádraig, * Pádraig Brady wrote on Mon, May 16, 2011 at 04:44:42PM CEST: > On 14/05/11 09:07, Paul Eggert wrote: > >> If something treats symlink mtime as significant, > >> then I suspect that it's at fault. > > > > Yes, there's something busted there. GNU 'make' does the right thing: > > it f

Re: bootstrap symlink dependencies

2011-05-16 Thread Eric Blake
On 05/16/2011 01:40 PM, Paul Eggert wrote: > lswords=`ls -1diL "$src" "$dst" 2>/dev/null` && > inum= && \ > for lsword in $lswords; do > case $lsword in > *[!0-9]*) ;; > *) if test -z "$inum"; then > inum=$lsword >elif test $inum -ne $lsword; then >inum= >

Re: bootstrap symlink dependencies

2011-05-16 Thread Paul Eggert
On 05/16/11 12:12, Eric Blake wrote: > On the other hand, it only works with POSIX > shells (Solaris /bin/sh doesn't understand the XSI notion of %% and ##). > Another option might be something like this (untested) lswords=`ls -1diL "$src" "$dst" 2>/dev/null` && inum= && \ for lsword in $lswords

Re: bootstrap symlink dependencies

2011-05-16 Thread Eric Blake
On 05/16/2011 12:57 PM, Jim Meyering wrote: > Paul Eggert wrote: >> On 05/16/11 07:44, Pádraig Brady wrote: >>> I tested your ls ordering trick on linux, solaris 10 and freebsd and it >>> works. >>> Please push. >> >> Thanks, done. > > Thanks. I appreciate the added comments, too ;-) > > What d

Re: bootstrap symlink dependencies

2011-05-16 Thread Jim Meyering
Paul Eggert wrote: > On 05/16/11 07:44, Pádraig Brady wrote: >> I tested your ls ordering trick on linux, solaris 10 and freebsd and it >> works. >> Please push. > > Thanks, done. Thanks. I appreciate the added comments, too ;-) What do you think of this addition? It may be more efficient to in

Re: bootstrap symlink dependencies

2011-05-16 Thread Paul Eggert
On 05/16/11 07:44, Pádraig Brady wrote: > I tested your ls ordering trick on linux, solaris 10 and freebsd and it works. > Please push. Thanks, done.

Re: bootstrap symlink dependencies

2011-05-16 Thread Pádraig Brady
On 14/05/11 09:07, Paul Eggert wrote: >> If something treats symlink mtime as significant, >> then I suspect that it's at fault. > > Yes, there's something busted there. GNU 'make' does the right thing: > it follows symlinks when checking time stamps. Is some other 'make' > is being used, or per

Re: bootstrap symlink dependencies

2011-05-14 Thread Eric Blake
On 05/14/2011 02:41 AM, Jim Meyering wrote: >> But this won't work if the file names contain spaces. > > Good point. But this does: > > inums=`ls -1diL "$src" "$dst" 2>/dev/null|sed 's/ .*//'` && set $inums && > test "$1" = "$2" || { > > However, it could still fail for any name containing

Re: bootstrap symlink dependencies

2011-05-14 Thread Jim Meyering
Paul Eggert wrote: >> If something treats symlink mtime as significant, >> then I suspect that it's at fault. > > Yes, there's something busted there. GNU 'make' does the right thing: > it follows symlinks when checking time stamps. Is some other 'make' > is being used, or perhaps some tool othe

Re: bootstrap symlink dependencies

2011-05-14 Thread Paul Eggert
> If something treats symlink mtime as significant, > then I suspect that it's at fault. Yes, there's something busted there. GNU 'make' does the right thing: it follows symlinks when checking time stamps. Is some other 'make' is being used, or perhaps some tool other than 'make'? > That looks

Re: bootstrap symlink dependencies

2011-05-12 Thread Jim Meyering
Pádraig Brady wrote: > I've noticed a few times when re-running bootstrap > within my coreutils directory, that the build will fail because > it seems that the timestamps of the symlinks in m4/ are used, > rather than those of the target m4 files. > > For example recently, @HAVE_SIGHANDLER_T@ was l

bootstrap symlink dependencies

2011-05-09 Thread Pádraig Brady
I've noticed a few times when re-running bootstrap within my coreutils directory, that the build will fail because it seems that the timestamps of the symlinks in m4/ are used, rather than those of the target m4 files. For example recently, @HAVE_SIGHANDLER_T@ was left unsubstituted in lib/signal.