Re: base64 decoding more tolerant to chars

2012-02-06 Thread Simon Josefsson
Bruno Haible writes: > Jim Meyering wrote: >> > Could also be done, but since the code to remove newlines was there, I >> > thought it is simpler to augment it to remove common garbage. >> >> I am reluctant to make this low-level decoding function ignore anything >> else. > > I agree. If you re

Re: base64 decoding more tolerant to chars

2012-01-31 Thread Bruno Haible
Jim Meyering wrote: > > Could also be done, but since the code to remove newlines was there, I > > thought it is simpler to augment it to remove common garbage. > > I am reluctant to make this low-level decoding function ignore anything > else. I agree. If you remove the garbage unconditionally,

Re: base64 decoding more tolerant to chars

2012-01-31 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: > On 01/30/2012 10:29 PM, Jim Meyering wrote: > >> Hi Nikos, >> Have you considered pre-filtering the data you pass to the base64-decoding >> function? We considered what you're proposing when adding the >> --ignore-garbage option to the command-line base64 program:

Re: base64 decoding more tolerant to chars

2012-01-30 Thread Nikos Mavrogiannopoulos
On 01/30/2012 10:29 PM, Jim Meyering wrote: > Hi Nikos, > Have you considered pre-filtering the data you pass to the base64-decoding > function? We considered what you're proposing when adding the > --ignore-garbage option to the command-line base64 program: Hello, Could also be done, but sin

Re: base64 decoding more tolerant to chars

2012-01-30 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: > This patch makes the base64 decoding tolerant on carriage returns, > spaces and tabs. It is quite common to find PEM encoded files (base64 > with new lines) containing such characters and having a tolerant decoder > is a plus. Hi Nikos, Have you considered pre-fi

base64 decoding more tolerant to chars

2012-01-30 Thread Nikos Mavrogiannopoulos
Hello, This patch makes the base64 decoding tolerant on carriage returns, spaces and tabs. It is quite common to find PEM encoded files (base64 with new lines) containing such characters and having a tolerant decoder is a plus. regards, Nikos >From c56e7ecd745c7e49bbf17bd907c7d305009b19d9 Mon Sep