Re: argp --help formatting bug with non-ASCII characters

2024-04-13 Thread Lasse Collin
On 2024-04-12 Bruno Haible wrote: > How to reproduce: > 1. Build GNU tar (1.33 or 1.35, for example). > 2. Install it. > 3. You can see misindentation: > $ LC_ALL=de_DE.UTF-8 src/tar --help > > ... > abzubilden > --mode=ÄNDERUNGEN den (symbolischen) Modus ÄND

Re: argp --help formatting bug with non-ASCII characters

2024-04-12 Thread Collin Funk
Hi Bruno, On 4/12/24 10:19 AM, Bruno Haible wrote: > So, my feeling would be that the first thing to do is to create a new > unit test for it: > 1. so that we don't need to build and try GNU tar in order to see > whether there is a regression in the future, > 2. so as to cover the tricky

Re: argp --help formatting bug with non-ASCII characters

2024-04-12 Thread Bruno Haible
Hi Collin, > This patch fixes the two examples that you gave. I think it may be > missing the case where the buffer doesn't end in a partial line > though. There are probably some other cases that are not handled either. The code is ca. 200 lines of considerations of columns and widths here and t

Re: argp --help formatting bug with non-ASCII characters

2024-04-12 Thread Collin Funk
Hi Bruno, On 4/11/24 4:23 PM, Bruno Haible wrote: > The bug is apparently that in argp-fmtstream.c, a character such as Ä or É > augments fs->point_col by 2, when it should only augment it by 1. > > In other words, it should use the Gnulib module 'mbswidth'. > > Any volunteers? I am very unfami

argp --help formatting bug with non-ASCII characters

2024-04-11 Thread Bruno Haible
Reported by Lasse Collin: The argp module from Gnulib has a rendering problem in the --help output of the program. Namely, it counts bytes when it should count screen columns. How to reproduce: 1. Build GNU tar (1.33 or 1.35, for example). 2. Install it. 3. You can see misindentation: $ LC_ALL=de_