Re: alt hash implementation

2009-06-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 6/17/2009 12:20 PM: >> Here's what I squashed to fix things: > > Thanks. I'd noticed ;-) > > I noticed another problem: this fails when n_buckets_used is 0: > > size_t needed = table->n_buckets_used - 1; Good catch

Re: alt hash implementation

2009-06-17 Thread Jim Meyering
Eric Blake wrote: > Eric Blake byu.net> writes: >> I got bored and attempted this. This implementation still passes the m4 >> testsuite, although there might be corner cases not exercised by m4 (such as >> shrinking the table on hash_delete) that I got wrong, so I'm posting it for >> review now.

alt hash implementation (was: [PATCH] hash: declare some functions with the warn_unused_result attribute)

2009-06-17 Thread Eric Blake
Eric Blake byu.net> writes: > > I got bored and attempted this. This implementation still passes the m4 > testsuite, although there might be corner cases not exercised by m4 (such as > shrinking the table on hash_delete) that I got wrong, so I'm posting it for > review now. In particular, I