Re: __builtin_expect used in regex

2018-10-17 Thread arnold
Hi. Paul Eggert wrote: > On 10/1/18 11:31 AM, arn...@skeeve.com wrote: > > Those changes look really excessive to me. I prefer to not have to > > keep including more and more files from gnulib just to compile regex > > or dfa. > > Sorry, I didn't read your message (I had misfiled it) until just

Re: __builtin_expect used in regex

2018-10-17 Thread Paul Eggert
On 10/1/18 11:31 AM, arn...@skeeve.com wrote: Those changes look really excessive to me. I prefer to not have to keep including more and more files from gnulib just to compile regex or dfa. Sorry, I didn't read your message (I had misfiled it) until just now, after I propagated the patch into

Re: __builtin_expect used in regex

2018-10-01 Thread arnold
Hi Paul, Paul Eggert wrote: > Thanks for reporting the problem. Please try the attached patch against > Gawk master. The ChangeLog entry is a bit optimistic, as it is assuming > that the patch works (and if it works, I would like to install the > relevant changes into Gnulib and into glibc, so t

Re: __builtin_expect used in regex

2018-09-30 Thread Paul Eggert
Thanks for reporting the problem. Please try the attached patch against Gawk master. The ChangeLog entry is a bit optimistic, as it is assuming that the patch works (and if it works, I would like to install the relevant changes into Gnulib and into glibc, so that at that point the ChangeLog entr

Re: __builtin_expect used in regex

2018-09-30 Thread Paul Eggert
Bruno Haible wrote: In gnulib, the module 'regex' depends on the module 'builtin-expect' (with the appropriate condition), and this latter module guarantees that __builtin_expect is defined also on non-GCC compilers. All true. However, __builtin_expect is being phased out in glibc and I'd like

Re: __builtin_expect used in regex

2018-09-30 Thread Bruno Haible
Hi Arnold, > Nelson, please chime in with a list of the system + compiler combinations > where gawk needs this patch. Basically, all platforms with a non-GCC compiler will need this patch. Think of Solaris cc, HP-UX cc, native Windows with MSVC... > As I mentioned, this is really a gnulib > issu

__builtin_expect used in regex

2018-09-30 Thread arnold
Hello GNULIB guys. Pleae see the patch below which Nelson needs in order to compile gawk on several of his systems. This comes from the use of the BE macro in regex. Nelson, please chime in with a list of the system + compiler combinations where gawk needs this patch. As I mentioned, this is re